Fork me on GitHub
#cryogen
<
2020-11-14
>
kingmob04:11:52

Sass fragmented into multiple versions. The older Ruby one was what Cryogen was originally built with, but I believe the interface is the same, so the simplest way to install is probably npm install -g sass

Jakub Holý (HolyJak)14:11:16

I will have a look, I do install it for my Netlify build too

Jakub Holý (HolyJak)14:11:48

Or we can configure cryogen not to look for it if it doesn't use sass

Jakub Holý (HolyJak)15:11:38

I've enjoyed reading https://circleci.com/blog/meet-the-interns-carmen-la/ :-) Thank you, Carmen, for sticking with Cryogen for so long!

❤️ 6
dorab17:11:12

@holyjak From what I've been able to read, I believe what is needed is to change the docker image to circleci/clojure:lein-2.9.3-node, add npm install -g sass (as mentioned by @kingmob), and possibly change the path key under store_artifacts to public.

Jakub Holý (HolyJak)20:11:38

Why would we need that when there is no sass stylesheet?

carmen20:11:46

There might be something in the config that triggers sass

Jakub Holý (HolyJak)21:11:27

This is the cause (update-in [:sass-src] (fnil identity ["css"])) Fix coming soon

dorab22:11:37

PR applied.

dorab22:11:49

There was still the issue with the path in store_artifacts. I fixed that (directly on master, not via a PR) and the CircleCI job now completes without any errors. Thanks for all the help. If it is all okay, I will bump up the version and tag it in the next few days.

dorab02:11:02

Just bumped version to 0.1.2 and made a release.

Jakub Holý (HolyJak)08:11:59

Awesome, thanks a lot!

Jakub Holý (HolyJak)22:11:42

That sounds as a great idea!

Eugen09:11:07

yes, but someone pointed out that libsass and consequently jsass and similar wrappers are being deprcated en-mass. jsass itself is in maintenance mode for that reason. They are working on something like libsass-protocol but doesn't seem to go anywhere for now. I think the best way to solve this for now is to improve the docs and recommend people install a compatible sass compiler.

Jakub Holý (HolyJak)17:11:11

Thanks for digging in to it. Then let's do that!

Eugen22:11:19

I'm working to make Live Reload work properly https://github.com/cryogen-project/cryogen/issues/118 and some feedback is welcomed. Right now it fails quite often with Page Not Found I believe this is caused because Cryogen does a lot of writes to disk: • whypes out the files • compiles and writes all files regardless if they changed or not ?! I believe this makes Live-Reload start when the files are deleted and it finishes when there is still no page rendered. This could be solved if Cryogen emitted events when it processes data and it finishes things. This way we could hook into those events and take action. Do you think it is a good addition for Cryogen? It could emit some events at start / end of each compilation phase. It could also emmit events when compiling content files. Something like:

{:src { :path "/content/asc/my-blog-post.asc"  :hash "md5-abcd"}
:dest {:path "public/posts/my-blog-post/index.html" :hash "md5-bcda" } }

Eugen09:11:14

Hi, I think it will. I saw your PR a while back and I thought it was a great idea. it is a step in the same direction for sure. I do think it will help, even if only by side effects (faster compilation time).

Eugen09:11:45

Is there a way to append changes to the change/set compilation pipeline? For example your code does not work for next/previous. Would it help if we add the previous/next files to the compilation queue as the compilation happens?

Jakub Holý (HolyJak)17:11:59

Not built in. We would need to make a more complicated (and maintainenance-expensive) change to enable that and personally I do not think it's worth that because who cares about those links during development? Why?

Eugen17:11:11

I was just curios if there is enough need for something like that. I'm not familiar with the code to know how hard it would be to implement. I think the event part would be nice.

carmen22:11:20

I just want to take a moment to say thank you to everyone that has been contributing to cryogen lately. I haven't really had the energy to work on cryogen, so I really appreciate you all coming together to review and merge PRs! ❤️

❤️ 6
dorab22:11:25

And, thank you for starting the project!

💯 3
Eugen22:11:33

here here 🍻

Jakub Holý (HolyJak)23:11:21

@carmen I'd be happy if you made me a contributor, if it is OK for you. And if we are multiple contributors, perhaps it would be helpful to write down a few guidelines, such as the general project philosophy (e.g. KISS to keep maintenance cost down, to keep a balance between user needs and stability and developer time) and "best practices" regarding testing before merging a PR, versioning and releases... . What do people think?

👍 3
carmen23:11:26

@holyjak that is a great idea, and I'd love to make you a contributor!

🙏 3
👍 3