Fork me on GitHub
#cryogen
<
2020-03-30
>
cpmcdaniel00:03:59

> Error: resource-path for /html/page.html returned nil, typically means the file doesn't exist in your classpath. Getting this now, for some reason

carmen00:03:58

@cpmcdaniel Windows problems 😅 there's an issue open for that right now https://github.com/cryogen-project/cryogen/issues/204 @yogthos and I don't run Windows so if you're able to tackle the bug that would be much appreciated 😄 Alternatively you could use an older version of Selmer since people have successfully used Cryogen on windows in the past

cpmcdaniel00:03:56

Ah, see I was using a docker image and a local volume to run cryogen from a docker container. Then I fired up Cursive/IDEA and tried running lein ring server from the IDE.

cpmcdaniel00:03:05

of course, there is also WSL (Windows Subsystem for Linux)

cpmcdaniel00:03:28

given the state of the clj tool itself on Windows, maybe we should just steer folks to use WSL

cpmcdaniel04:03:33

I think I have a fix for issue 204

💯 4
cpmcdaniel04:03:53

I'll try to get a PR together for it

cpmcdaniel04:03:44

I haven't done PRs from a fork in a while. Is it customary just to make the commits in master in my fork and submit a PR from there, or is it generally better to do my work in a branch?

teh0xqb12:03:13

Hey. I would work in a branch. iirc You can set up the PR with a different origin (fork source) into master regardless. Then, once the PR is accepted and merged, your fork’s master would be clean and you can pull latest master cleanly into your fork.

cpmcdaniel12:03:56

Yeah, I looked at some other PRs as an example and did it that way

👍 4
teh0xqb12:03:05

you’re always online now

cpmcdaniel12:03:27

lol I stayed up a little too late last night working on this.

cpmcdaniel16:03:21

I also found that the Selmer unit tests had the same issue (using getAbsolutePath instead of getAbsoluteFile) and were failing on Windows, along with some others that were failing because of line separators: https://github.com/yogthos/Selmer/pull/218