hello, I'm trying to patch a JS promise to respond as a channel, but I guess I'm doing it wrong, can someone clarify how the ReadPort/take! method is supposed to be implemented?

here is my current attempt (which doesn't work):

(extend-type js/Promise
  async.protocols/ReadPort
  (take! [port f]
    (.then port f)))

and here is the code I would like to work after that:

(let [p (.resolve js/Promise "VALUE")]
    (go
      (let [x (<! p)]
        (js/console.log "PRO" x))))

rather than making another channel @wilkerlucio , have you considered doing something like:

(let [ch (chan)]
  (.then promise #(put! ch %))
  ch)

@ghadi this is what I'm doing so far (with a wrapper function), but that is kind annoying, because then I have to do it everytime I see a promise

would be nice if I could just use then directly

the f is not an actual callback but a channel 'handler' -- personally I suggest keeping your wrapper function

see https://github.com/clojure/core.async/blob/105acd5b40a66b6d1c80271a30ae273c6933c5bd/src/main/clojure/cljs/core/async/impl/channels.cljs#L44-L163 for the channel implementation. It's not trivial...

@ghadi thanks, actually I found just what I was looking for here: https://github.com/jamesmacaulay/cljs-promises/blob/master/src/cljs_promises/async.cljs#L21-L35

it does the wrapping in a nice easy way 🙂

because I only need to deal with the reads

Clojure type system is so lovely 🙂

you can't troll us

another nice type system on display here @wilkerlucio https://github.com/LuxLang/lux/blob/master/stdlib/source/lux/type/auto.lux#L308

which logging library fits well with core async ?