Which vim-which-key does the PR talk about? I can't understand where is the link :thinking_face: Edit: This one: https://github.com/folke/which-key.nvim

So this PR actually breaks a bunch of things I think? I'm working to integrate it in a compatible way now.

This plugin was crashing before but somehow it now doesn't crash and on Conjure master I see this (I think the PR only adds text messages but I didn't actually care because function names are readable too (also I looked at the source of Conjure so there is not much use from texts for me (but these repeat things in names are weird))):

I'm changing that right now. I'm having to rewrite how mappings are defined which will fix a bug around repeat + input prompts and fix this display.

It hasn't changed on master for a very long time, it'll only change on develop.

Will it break the way you create the functions too? Or will it only impact repeats?

I don't know what functions you mean, but I don't think any functions are changing. Just the way I create mappings and commands

I've overriden some bindings in my config and created some new ones. But from what you say it shouldn't be a problem.

I don't think so. I'm migrating it all to mapping.buf2 at the moment and will remove the original mapping.buf eventually which you may be calling? The new one is much better and uses the newer features to integrate Lua functions correctly as first class citizens.

Actually I don't bind it from my plugin and instead create nvim functions: https://github.com/Invertisment/conjure-clj-additions-nrepl/blob/master/fnl/conjure-clj-additions-nrepl/main.fnl#L8 I thought that if you're moving away from this maybe you want to remove something else which could break something.

Nope, just internal changes to fix bugs / improve features

shouldn't really notice I hope

other than repeat works properly and more mappings have documentation

Also what do you think about having the functionality that I have in my plugin inside of Conjure? It works and I actually don't understand why I have to add nREPL as a dependency myself on my ~/.lein/profiles.clj . Do you use some kind of simplified nREPL and you don't want to use full one (not sure how it works)?