Fork me on GitHub
#conjure
<
2021-01-26
>
dharrigan08:01:56

There is something missing for the eval form and that's eval current word and store comment

dharrigan09:01:47

So, if I have something like this (def x-token (authenticate app-config)) then I would normally do ,ew over x-token to get it's value. It would be nice if I could do ,ewc to store that like a comment too

Olical10:01:13

If I add this it's only a matter of time before someone asks for "eval root form and comment" too. So I went down the simple option of "only current form" for this implementation so far, but I've done the hard part (adding comments in the correct way).

dharrigan10:01:38

Yeah, I thought it might be considered a slipperly slope

Olical10:01:42

To do this style, I think I need to rewrite / redeisgn the comment result thing system. So it'll be a prefix to any mapping :thinking_face:

Olical10:01:48

Like ,ece to do current form

Olical10:01:57

A little more buttons, but more general

Olical10:01:07

,ecr and ,ecw would work then

dharrigan10:01:47

that makes sense

Olical10:01:00

Also practicalli mentioned wanting ;; over ;, but I think that'll be a setting with ; being the default for internal implementation reasons in Conjure.

Olical10:01:15

Just FYI, thought you might be interested in that idea too maybe

Olical10:01:27

I personally prefer single commented code and double commented prose etc but yeah

dharrigan10:01:49

I normally use ;; 🙂

dharrigan10:01:57

but <shrug> not a biggie for me

dharrigan11:01:40

maybe it could be a configuration parameter

dharrigan09:01:57

even if I put x-token on a separate line and do ,ew it works (shows as virtual text), but then doing ,ec only shows nil, as ,ec only works with forms atm 🙂

dharrigan09:01:29

Happy to raise this is as issue 🙂