Fork me on GitHub
#conjure
<
2020-08-12
>
adambros19:08:59

upgrading to 4.1.0 to 4.2.0 (wanted to turn on conjure#log#wrap) breaks my <localleader>cf (always gives "No nREPL port file found") copying .nrepl-port to src/dev when running ,cf in src/dev/user.clj fixes it seems like it's no longer doing this:

`g:conjure#client#clojure#nrepl#connection#port_files`
            ...
            Conjure checks every directory above your current one
            ...
I can make this a github issue if this is indeed a bug

olical19:08:42

Hmm that is most definitely still working fine for me.

olical19:08:26

What does :cwd show?

adambros19:08:40

i have set autochdir so it shows src/dev

olical19:08:25

I've never used that option so maybe it's helping expose a more subtle issue

olical19:08:39

I'll take a look in ~30 minutes

adambros19:08:58

This isn't urgent, I can work around it pretty easily for a day or two, so no rush from me

adambros19:08:49

(technically i'm using au BufEnter * silent! lcd %:p:h, forget why lol)

olical19:08:39

I can repro! 😱 I'm sure it's something simple

olical19:08:47

Thank you for bringing it to my attention.

olical19:08:03

(the odd part is that the related code hasn't changed)

adambros19:08:28

git bisect to the rescue?

olical19:08:40

Quite possibly 🤔

olical20:08:45

Oh wow, I know what it is.

olical20:08:03

I've got two functions called resolve in my fs module

olical20:08:40

Which works similarly, but not the same, which is why it was hidden partially

olical20:08:52

This should be fixed on develop

olical20:08:02

If so, I'll get this published in a patch

olical20:08:50

@adambros (sorry I should've used a thread! Also no rush to test it!)

olical20:08:27

I have now renamed all of the functions that were waaaay to close in name to much more specific names.

olical20:08:56

Also thank you so much @orestis for the sponsorship! 😱 ❤️

olical20:08:50

DM me if you're interested in me posting you a couple of Conjure stickers, I'm building up a list of addresses, I'll make a post office run some day soon-ish

olical20:08:58

(although I'm away on holiday next week)

adambros20:08:00

@olical can confirm that develop fixed it, thanks for the quick turnaround!

olical20:08:01

Fixed and released, although I accidentally tagged the wrong commit at first... so... released twice!