Clojurians Log v2
Clojure programming
Channels
Apps
code-reviews
Nundrum 2024-12-10T23:17:04.959159Z
I think I'm ready to submit to a code review on this from anyone that's bored with aventing 😄 https://github.com/robbieh/XScreenBane/tree/dev Mainly on the main/core/color parts, as well as the docs. I know it's a bit esoteric with all the JNA/X11 bits, but I think that's all well encapsulated. I hope it's pretty obvious what this does and how to add new hacks to it. I feel like it's close to ready for a real release, but something keeps holding me back.
daveliepmann 2024-12-11T08:54:24.571609Z
the defs within a defn which are in turn called from another fn are a bit of a red flag for me. what lead you to that choice?
daveliepmann 2024-12-11T09:01:24.340609Z
the transform with recursive-paths seems like a line worth an explanatory comment, but that's from a specter skeptic so maybe it's fine as-is if you're confident you're ready to commit all-in to that lib
Nundrum 2024-12-11T13:19:30.678639Z
You're right - I should clean up those inline defs. That made it easier for me to figure out the X11 interop at the time, but in the end only needed a few of those vars.
Nundrum 2024-12-11T13:22:14.054719Z
And I'll give that transform another look. It is a beast. There might be a simpler way to tackle it, maybe by making it two steps instead of one.
Nundrum 2024-12-11T13:22:18.662909Z
Thank you for taking a look!
👍 1