Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2021-06-03

Channels

#code-reviews
<
2021-06-03
>
tugh23:06:52

idk if this is the correct channel but i couldnt find a channel dedicated to kibit. i've added an if-not form and kibit's check time reduced from 6+ mins to 1- mins for our codebase. tests are passing but i cannot be sure if this breaks something or not. i need your reviews on this commit. https://github.com/Pisano/kibit/commit/aa8f349b09d7d2af3447a575ef3004d8b82f162e

noisesmith17:06:42

any specific motivation for special casing list and lazy-seq rather than using something more abstract?

noisesmith17:06:39

ISeq might be relevant 

user=> (set/intersection (supers (class (lazy-seq nil))) (supers (class (list))))
#{java.lang.Iterable java.util.List clojure.lang.IPersistentCollection java.io.Serializable java.util.Collection clojure.lang.IMeta clojure.lang.ISeq clojure.lang.IHashEq clojure.lang.Seqable clojure.lang.Sequential clojure.lang.IObj java.lang.Object clojure.lang.Obj}