Fork me on GitHub
#code-reviews
<
2021-01-20
>
roelof17:01:49

im busy with my first web project which is not done. I have to add more shelves and images

🎉 3
noisesmith17:01:39

@roelof that's a decent start, I'd normally move the hiccup related stuff into a separate ns (since there's so many lines of code related to it, especially with the data literals), and I'd definitely have some style suggestions if I got it as a PR (minor stuff like indentation and simplifying by using different core functions). but overall it's decent (if it gives the output you expect :D)

noisesmith17:01:26

(also the dot files .calva, .clj-kondo .lsp) are not part of your project and should not be in your repo)

roelof18:01:29

oke, you may always say what I can more simple

roelof18:01:54

and move the whole hiccup to a new ns I can do

roelof18:01:27

and maybe use different methods for the html parts ?

👀 3
roelof18:01:33

or making a PR what to change so I can learn from it