Fork me on GitHub
#code-reviews
<
2019-12-21
>
Andros15:12:25

Hello, I would like you to give me feedback on a new web framework I am developing. I've posted a cut-down version for small jobs. Thanks in advance.

Eric Scott23:12:17

I think you might want to reconsider your choice of namespace leiningen.new.tadam-lite, since it gives the impression that this is part of leiningen.

jjttjj23:12:33

It's probably necessary to write some explanation of what the library does or example usage or something

Andros08:12:42

It was my next goal, a little tutorial. Thanks for the advice!

seancorfield23:12:03

@eric.d.scott That's the namespace lein new expects -- that's how you write Leiningen templates.

seancorfield23:12:57

It is part of Leiningen in a way, because it's a template that lein new (or boot -d boot/new new or clj -A:new) know how to read and create a new project from.

seancorfield23:12:08

And here it is on Clojars https://clojars.org/tadam-lite/lein-template with the group ID tadam-lite and the required artifact ID lein-template

seancorfield23:12:20

Boot templates all have an artifact ID of boot-template and will have boot.new.* in their namespace name. CLI/`deps.edn` templates will all have an artifact ID of clj-template and will have clj.new.* in their namespace name -- although clj -A:new can also use local templates on disk and projects in a git repo: they don't need to be published to http://clojars.org.

seancorfield23:12:49

(Sorry, I know that's not "code review" stuff but it seemed important to point out why tadam has that namespace)