Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2019-01-07

Channels

#code-reviews
<
2019-01-07
>
noisesmith18:01:51

@mathpunk a minor thing, the require block makes this line redundant

mathpunk18:01:57

Ah. Having required cyclotron.case as case, ::case resolves correctly

mathpunk18:01:01

good to know

noisesmith18:01:53

using alias for keyword namespaces that don't exist as code namespaces is a nice trick though - it would likely make other namespaces clearer (I assume they were written before you discovered this trick)

mathpunk18:01:09

I think so. What I was going for is, there were certain ideas that seemed distinct sub-ideas --- like the idea of counting failures --- but that were just data and didn't need functions

noisesmith18:01:24

here if you used io/resource you could reliably point to something inside the repo (but perhaps it's intentional also that the sample data is not in the repo) https://github.com/mathpunk/cyclotron/blob/master/src/cyclotron/utils.clj#L11

noisesmith18:01:06

but I also see io/as-file io/resource "reports" elsewhere which doesn't reflect anything visible in the repo