Fork me on GitHub
#code-reviews
<
2018-10-23
>
dazld12:10:18

thanks for that feedback and review - we went through it and it ended up much simpler - https://github.com/dazld/batches

noisesmith16:10:32

@dazid if some other code closes the in channel, your code will go into a fast loop repeatedly accumulating nils in your vector

noisesmith16:10:02

there's also a problem of writing to out after it's closed, but the misbehavior is less serious