Fork me on GitHub
#code-reviews
<
2017-04-05
>
freekpaans11:04:07

hi all, i'm looking for feedback on a project i recently open sourced. anyone interested?

sveri12:04:59

@freekpaans It would be useful to link the project, so people can see what its about

sveri12:04:42

@freekpaans The first thing that comes to my mind is if you enforce a coding style and automatically reformat your files?

freekpaans12:04:19

@sveri you mean if i have that enabled?

sveri12:04:32

yes and if you use it

freekpaans12:04:06

not a separate tool, but i let vim do it

sveri12:04:55

Ah ok, I was just confused by the linebreaks in the require expression: https://github.com/infi-nl/alibi/blob/master/src/alibi/web.clj#L6

sveri12:04:00

as long as its conistent

freekpaans12:04:03

ah, that's because i try to keep things within 80 chars

freekpaans12:04:37

though that line would pbb have fit 🙂

sveri12:04:03

For me personally 80 lines is to short, but, I usually write Java 😄 Anyway, a tool should do that automatically in an ideal world, cursive does it not and I dont know if any other does that

hlolli13:04:44

@freekpaans add js-joda to cljsjs?

hlolli13:04:14

and why do you need it, just curious why moment.js isn't enough.

freekpaans13:04:44

i like the joda time apis, and momentjs is mutable iirc

freekpaans13:04:10

adding js-joda to cljsjs is on my list 🙂

hlolli15:04:19

if joda-time makes time immuteable, then I need it on the weekends 🙂

slipset17:04:41

There is of course cljs-time