Fork me on GitHub
#code-reviews
<
2016-12-20
>
sveri21:12:44

@roelofw Something non clojure specific. Its better to ignore the .idea folder and *.iml files. Or any other IDE specific stuff. This should be generated by the build tool or handled by the IDE itself.

roelofw21:12:06

oke, I will change that

roelofw21:12:24

I know I can do that with git ignore file

roelofw21:12:45

I do not know if these folders get deleted the next time I put them in the ignore file

sveri21:12:31

You have to remove them from git explicitly, once they were added, even after adding them to the .gitignore file. The same goes for profiles.clj which explicitly states it should be in .gitignore in its comment.

sveri21:12:41

do-both-in-parallel-detail what is both? The name could be better

roelofw21:12:16

oke, done with deleting the files from github

roelofw21:12:45

the function takes care that both files are executed in parallel

sveri21:12:34

Try to express what the function does in the name. Also do not express how the function does that (parallel or not is an implementation detail which does not belong into the function name)

roelofw21:12:25

oke, I will try to make up a better name

roelofw21:12:35

any recommendations?

sveri21:12:24

Also any log file does not belong into source control

sveri21:12:41

and the log itself not into the "src" folder

sveri21:12:25

maybe fetch-paintings-and-images

roelofw21:12:24

changed it also

sveri21:12:56

In general format the whole file and remove the empty lines at the end of the file

sveri21:12:14

closing parantheses belong to the end of the line and not on the next line

roelofw21:12:05

@sveri which file are you talking about

roelofw21:12:33

changed that

roelofw21:12:47

the reformat I let cursive do the formatting

sveri22:12:06

did you commit already?

roelofw22:12:49

nope, I busy with some reformatting

roelofw22:12:33

now committed

roelofw22:12:54

If you have more feedback then I will read it tomorrow. Now time to sleep

roelofw22:12:02

Thanks a lot for the feedback

sveri22:12:06

Yea, for me too, have a nice day 🙂

sveri22:12:10

night 😄

roelofw22:12:24

I wish you the same

roelofw22:12:48

and I hope your are satisfied how I deal with your feedback

sveri22:12:48

hehe, its not about me. You should be satisfied with yourself 😉

roelofw22:12:08

of course, but it is always good to see that some one is doing something with the remarks you made