Clojurians Log v2

It doesn't seem to pick up aliases. That is, it's as if the command like option was missing. By exit code passthrough I mean that cljr should return the exit code of the application being executed. So if I have an application with (System.Environment/Exit 1), the exit code from running it with cljr should be 1. The issue came up as a result of https://github.com/weavejester/medley/pull/96 - the submitter had put in a few hacks to get cljr to work, and when I tried I had the same issues they did.

$ cljr -X:deps tree
Starting exec/tool
Unqualified function can't be resolved: tree

If you have any samples that might shed light on the alias issue, please share. I have done basic testing, as I mentioned, but there may be situations where it falls short. I'll get a fix up for the exit code. Missed that in the original source.

I'm going to guess a Linux difference on the arg problem. There was some special case code for Windows arg handling in the clj source. Perhaps my version messes up for non-Windows. If I don't get to it today, I'll be sitting in my hotel room tomorrow afternoon and evening in advance of the Conj. Seems fitting to work on it there. 🙂

We were trying to get a test runner working. The contributor originally looked at https://github.com/clojure/clr.core.cli?tab=readme-ov-file#running-tests, but had to add a number of hacks to get it working, see: https://github.com/weavejester/medley/blob/88092c6e812c719aa3a4c657a7a70b6bbc112a0d/.github/workflows/test.yml#L39. The GitHub action in the PR could be a basis for some Linux-based smoke tests to check basic features like aliases etc. I should add that there's no hurry to fix this (at least on my end!), please enjoy the Conj.

I think you may be right in that this issue is linux-specific. I’m using MacOS and getting the same Unqualified function message from cljr -X:deps tree.

There is no hurry on my end either! This can wait until after Conj.

That should be enough of a hint to make progress. Thx.

Not that you need the blow-by-blow description, but the error does not appear to be in the C# code that parses the command line args and then passes them to Clojure (which runs the -main in clojure.run.exec). The same args are getting passed to the Clojure process on Linux as on Windows. Which leaves either the code that computes the classpath, basis, etc. and the code executes the tools: clojure.run.exec/-main. At least two errors are making an appearance under Linux. (Runs just fine under Windows.)

cljr -X:deps tree
Starting exec/tool
Unqualified function can't be resolved: tree

 cljr -X:test
Starting exec/tool
No function found on command line or in :exec-fn

This is working great! Aliases are now getting applied as expected.

Thanks for your work on this. There’s still the issue of exit codes not propagating up from clojure, which means I still need to use a test-runner wrapper to force GitHub steps to fail. Once that’s done, however, I think that should take care of everything on our end.

I had this nagging feeling I had forgotten something. It was late. Alpha4 just pushed to nuget with a fix for the exit code.

That was fast. I’ll check it out soon. Thank you!

Looks to be working on my mac as well as in GitHub actions

Okay, back from the Conj. Lots of great talks! I just published version 0.1.0-alpha3. Things now work on Linux. Running Ubuntu under WSL:

david@DESKTOP-IBDM5GL:~/test/clr.core.memoize$ cljr -X:deps tree
Starting exec/tool
io.github.clojure/clr.core.cache v1.1.234
  . io.github.clojure/clr.data.priority-map v1.2.0
david@DESKTOP-IBDM5GL:~/test/clr.core.memoize$ cljr -X:test
Starting exec/tool

Running tests in #{"src/test/clojure"}

Testing with Clojure 1.12.0-alpha10

Testing clojure.core.memoize-test

[... test output omitted ... ]

Ran 17 tests containing 206 assertions.
0 failures, 0 errors.