(max 1 ##NaN) => ##NaN, as expected. But (max ##NaN 1) => 1. Bug?
Personally, I'd treat it as GIGO.
But seems that both clojure.core/max and js/Math.max treat NaN in a special way.
Yes. But also consistency. Order of arguments shouldn’t matter in this case.
Also, (min ##-Inf ##NaN ##Inf) => ##Inf, which is wrong in so many ways.
If you treat it as GIGO, it all makes sense. :)
But apparently it's actually well defined for both Java and JavaScript to return NaN for Math.max, so yeah, might make sense to be consistent.
Clojure JVM returns ##NaN for all these cases.
BTW, ClojureScript min suffers from all the same issues.
There's enough differences between the platforms that relying just on Clojure's behavior makes little sense. The context is important. But not so much in this case, since the behavior is the same everywhere, and is explicitly defined.
Where are ClojureScript bugs filed?
Same as for Clojure - http://ask.clojure.org. You can also mention it in #cljs-dev
Thanks for the report, will fix
missing source maps should never cause a problem for a browser client application right?
Yes. Unless that app deliberately makes source maps its business for some reason.
Thanks, yeah. Im realizing that there are several network calls resulting in 404, the missing source maps warning/error was one of many. im not sure why the prod app is asking for source maps, but it's a symptom, not a cause of the woes.
The app itself probably doesn't ask for them. If you have the DevTools panel open, your browser itself will ask for source maps.