dotimes returns nil so the p/let has no promise it can await

You probably want something like (p/let [... (apply p/all (repeatedly 5 long-running))] ...). repeatedly may not be exactly what you're looking for, but it sounds like you want a promesa/all around whatever sequence you're building

(but yeah, you have to build a sequence)

Ah ok let me give that a shot thank you

It looks like that doesn't work either, apply says p/all isn't a function, and I can't wrap it in p/all either or it still doesn't wait for the return

https://github.com/funcool/promesa/blob/master/src/promesa/core.cljc#L347

it's a function, i promesa

I think the problem is I am trying to wrap multiple steps inside an anonymous function ie #(do (long-1) (long-2) ...) and it only waits for the last one, maybe I need to wrap those all in ->

no, you really do want (p/all [(long-1) (long-2) ..)

Yeah I just need to somehow wrap those two long calls in a repeatedly or for loop

Cut and pasting them works file, it just feels a little silly

This almost works: (p/let [... _ (repeatedly 5 (p/-> (long-1) (long-2))]) I am just now getting "Cannot read properties of undefined (reading long-1)" error message

dude that code is so far away from working

You need p/all

(repeatedly takes a function, you're not passing it one, the semantics of p/-> aren't what you want, even if were passing it a function, repeatedly returns a sequence, which p/let can't await on, unless it's wrapped in p/all, etc.

It's not clear what you're trying to do. If you have n distinct functions, then you want (p/let [x (p/all [(long-1) (long-2) ...])] ...) . if you have n distinct parameters, you want e.g. (p/let [x (p/all (for [i (range 10)] [(long n)))] ...) if you want to call the same function n times, you want (p/let [x (p/all (repeatedly 10 long-n))] ...

This is super helpful I am just re-reading this thread and comparing it with the code to connect those dots in my head

I have this but it doesn't wait as long as I would expect (I have each call waiting on a 1 sec timeout and all of them together appear to only wait 1 sec):

(p/let [_ (apply p/all [(take 10 (cycle [#(long-1) #(long-2)]))])])

you don't need the apply

but the behaviour you describe is what you should expect

the promises are being resolved concurrently

Ah I want them to be sequential

I just tried the reduce - chain but that didn't appear to wait, and I also tried a p/do but it throws an error because its a macro and not a function

yeah that was a janky suggestion, i'll give you something better once i'm off the phone

(reduce p/then (p/resolved nil) (take 10 (cycle [long-1 long-2))])

something like that

That worked thank you for sticking with me through this thread, very educational

If I were to rephrase this solution, is this correct? Starting with a unresolved promise, take the list of functions and chain them with 'then'

starting with a resolved promise

just to act as the initial value for reduce, so you don't have to invoke any of your functions yourself

Why would you write it like that? Why not just (.normalize s "NFD")?

Also, I doubt that it works in plain CLJS - (js/String.prototype.normalize) calls String.prototype.normalize with no arguments, so it returns an empty string.

I doubt this changes the string (.normalize s "NFD")

(remove-accents "Joãn") works pretty good

What do you mean by "I doubt this changes the string"?

This is plain CLJS, without any tools:

cljs.user=> (require '[clojure.string :as str])
nil
(defn remove-accents [s]
    (let [normalize-fn (js/String.prototype.normalize)
          accent-re (js/RegExp. "\\p{M}")]
      (str/replace (normalize-fn.call s "NFD") accent-re "")))
#'cljs.user/remove-accents
cljs.user=> (remove-accents "Joãn")
Execution error (TypeError) at (<cljs repl>:1).
Cannot read properties of undefined (reading 'call')

The reason it might not work in your environment might probably be your javascript version or clojurescript version, but it does work perfectly in my environment, the issue is that on my browser, shadow-cljs throws that error

It's not shadow-cljs, it's JS that throws that error.

As I said, your code cannot work, unless your version of JS is doing something horrible. Or maybe something has overwritten String.prototype.normalize to be a function of no arguments that returns the actual normalize function.

(js/String.prototype.normalize) in CLJS compiles to String.prototype.normalize() in JS. That's true regardless of the version of CLJS or JS and of the tools that you're using. And using String.prototype.normalize() just doesn't make sense. It returns an empty string, not a function.

Oops, you are correct, there was conflict i was using the hardcoded, conflict on my repl

(defn remove-accents
  "remove accented letters"
  [s]
  (let [accent-map {"á" "a" "é" "e" "í" "i" "ó" "o" "ú" "u" "ñ" "n" "ä" "a"
                    "Á" "A" "É" "E" "Í" "I" "Ó" "O" "Ú" "U" "Ñ" "N" "Ä" "A"
                    "à" "a" "è" "e" "ì" "i" "ò" "o" "ù" "u" "À" "A" "È" "E" "Ì" "I" "Ò" "O" "Ù" "U"
                    "â" "a" "ê" "e" "î" "i" "ô" "o" "û" "u" "Â" "A" "Ê" "E" "Î" "I" "Ô" "O" "Û" "U"
                    "ã" "a" "õ" "o" "Ã" "A" "Õ" "O"
                    "ç" "c" "Ç" "C"
                    "đ" "d" "Đ" "D"
                    "ğ" "g" "Ğ" "G"
                    "ı" "i" "İ" "I"
                    "ł" "l" "Ł" "L"
                    "ń" "n" "Ń" "N"
                    "ø" "o" "Ø" "O"
                    "ş" "s" "Ş" "S"
                    "þ" "th" "Þ" "TH"
                    "ü" "u" "Ü" "U"
                    "œ" "oe" "Œ" "OE"
                    "æ" "ae" "Æ" "AE"}]
    (apply str (map (fn [c] (get accent-map c c)) s))))

But still (.normalize "Joãn" "NFD") returns => "Joãn"

That's because you need more than just normalization - you also need replacement.

I tried replacement, still returns the same string

Perhaps the regex is not the right one. But nothing to do with CLJS.

Yeah, you gotta use the u flag. This works in JS:

"Joãn".normalize("NFD").replace(/\p{M}/gu, '')

However, neither NFD nor NFKD seem to decompose œ, for whatever reason.

A relevant comment: https://stackoverflow.com/questions/7171377/separating-unicode-ligature-characters#comment8621777_7171932 The next comment is also useful.

Probably by inspecting the compilation environment - can’t be done at runtime

Thank you, yes, compile time is ok for what I'm trying to do. Should I try to use cljs.analyzer.api for this ?

I think that you can use #CHY97NXE2 :analysis API.

Thank you, nice to know !

I recommend Reitit https://www.metosin.fi/blog/reitit/.

This blog post is also a good resource https://ericnormand.me/mini-guide/clojure-routers.

I actually found that article while I was looking! Working on setting it up now