for some reason it doesn't seem to pass keywords as first argument

if i have a protocol fn (expand [_ _]) and try to call it like (expand :some-keyword {:a 1}) i get the same map in both arguments

if i have a protocol fn (href [_] [_ _] [_ _ _]) then trying to call it as (href ::some-keyword) will error saying there's no implementation for the protocol for null

the protocols are defined in cljc files

Can you share more code? It seems like you are not passing the type that implements the protocol as first argument

E.g. do you use defprotocol and extend-protocol? Or extend-type or reify?

i'm passing a hardcoded keyword

that's why i'm super confused

it says i'm passing nil or an arraymap when i'm clearly not

i use defprotocol and extend-protocol

Can you share how you use defprotocol and extend-protocol?

did you implement the protocol for keywords?

the first arg is always the thing that implements the protocol. so if you don't implement it for keywords you get an error

in that case i get a protocol not implemented for type error, not this

what is "this" precisely?

Uncaught Error: No protocol method ByName.href defined for type null: 

(href ::web/ping)

i have no idea how it manages to turn a hardcoded keyword into null

it very likely doesn't. did you verify that you are looking at your exact piece of code? ie. by commenting it out?

yes

and you implemented the prtocol in a non-recursive fashion where it calls itself, which maybe some other logic you did?

Hmm that narrowed it down a little. So I have this protocol

(defprotocol ByName
  (href [_] [_ _] [_ _ _]))

(extend-protocol routes/ByName
  Keyword
  (href
   ([route]
    (js/alert "a" route)
    (href route nil nil))
   ([route params]
    (js/alert "b" route)
    (href route params nil))
   ([route params query]
    (js/alert "c" route)
    (easy/href route params query))))

Similarly I have a protocol

(defprotocol Expand
  (expand [_ _]))

(extend-protocol routes/Expand
  Keyword
  (expand
   [route-name opts]
   (expand {:name route-name} opts))

  PersistentArrayMap
  (expand
   [{route-name :name :as route} _]
   (conj route (route-defs route-name)))

  PersistentHashMap
  (expand
   [{route-name :name :as route} _]
   (conj route (route-defs route-name))))

I have never seen cljs behave like this and I got no idea what I could've messed up. I've tried clearing the .shadow-cljs and public/js folders, no luck.

here i committed it https://github.com/valerauko/shared-routing/blob/main/src/shared_routing/router.cljs

Not even sudo rm -rf node_modules .shadow-cljs public/js helped...

I'd suggest not making a muti arity protocol in the first place

make a regular defn for that, which then calls the protocol

i can't because of circular dependencies

for a defn?

anything that call the protocol can call a defn

i understand that. i just realized that in this case href doesn't have to be a protocol. that however doesn't explain the issue with the protocol that has a sinlgle [ ] arity

the code likely is just buggy. I see at least one above

expand in for keyword calling expand?

but the protocol is in another namespace, so why is this not qualified? or do you have a refer?

yes https://github.com/valerauko/shared-routing/blob/8f0b4c37172da7198c9bba94e03c429294586492/src/shared_routing/router.cljs#L6

(not refering and instead using routes/expand does not fix the issue)