How would I add a static method to a clojurescript deftype (or any other common mechanism - defrecord or protocols are also ok)? I’m trying to convert this fragment to cljs:

class SimpleImage {
  static get toolbox() {
    return {
      title: 'Image',
      icon: '<svg width="17" height="15" viewBox="0 0 336 276" xmlns=""><path d="M291 150V79c0-19-15-34-34-34H79c-19 0-34 15-34 34v42l67-44 81 72 56-29 42 30zm0 52l-43-30-56 30-81-67-66 39v23c0 19 15 34 34 34h178c17 0 31-13 34-29zM79 0h178c44 0 79 35 79 79v118c0 44-35 79-79 79H79c-44 0-79-35-79-79V79C0 35 35 0 79 0z"/></svg>'
    };
  }

  render(){
    return document.createElement('input');
  }
}

(deftype Foo []
  (render [this] ....))

Somehow having clojurescript in deps (*clojure cli ver 1.10.3.1087)* is causing the wrong version of clojure.data.json to be in the classpath: as expected, with just current data.json

clj -Sdeps '{:deps { org.clojure/data.json {:mvn/version "2.4.0"}}}'

Clojure 1.10.3
user=> (require 'clojure.data.json)
nil
user=> (clojure.data.json/write-str (java.time.Instant/now))
"\"2022-03-08T18:34:30.019053Z\""

clj -Sdeps '{:deps {org.clojure/clojurescript {:mvn/version "RELEASE" :exclusions [org.clojure/data.json]} org.clojure/data.json {:mvn/version "2.4.0"}}}'

Clojure 1.10.3
user=> (require 'clojure.data.json)
nil
user=> (clojure.data.json/write-str (java.time.Instant/now))
Execution error at clojure.data.json/write-generic (json.clj:385).
Don't know how to write JSON of class java.time.Instant

ClojureScript embeds a version of data.json

because it's embedded, it's not visible to external dependency version selectors and where it ends up on the classpath will affect what version is used

Thanks Alex. I wonder if that can be fixed

@henryw374 I believe there is a non-AOT artifact? I can't remember \cc @alexmiller

non-AOT artifact for ClojureScript?

for data.json, there are both and cljs uses the AOT but that's really orthogonal to this problem

clojurescript is a bad actor here in "hiding" a copy of a dep inside itself such that it's not visible to version selectors outside the libs. really, you should never do that in published artifacts without shading to move it to a custom ns (like org.clojurescript.data.json or whatever) - at that point there is a copy but no conflict, users can use both and everyone is fine

this has not historically been an issue primarily because data.json did not change its api, but now there have been additions so that difference is visible

I'm not against shading it - I thought ClojureScript had a sources only jar?

slim or whatever

No, it does include a compiled version of data.json.

@p-himik I mean there is another artifact

it used to be you had to ask for the aot one

Ah, gotcha.

But practically speaking - seems like everybody adds org.clojure/clojurescript to their dependencies, so everybody ends up having those AOT artifacts. And it's not just data.json.

also includes tools.reader and transit-clj and transit-java