If anyone would like to help me hack the cljs compiler, im adding native class support

https://github.com/flyboarder/enterprise/blob/master/src/degree9/es6.clj

@flyboarder woah nice!

are you intending to submit a patch?

not currently, I think this needs some real world testing first

there's an open JIRA I submitted recently about this exactly

yeah I have read it, my personal use case is on node.js with a project that requires I extend existing classes

nice. if it's any inspiration, here's the syntax I chose for helix (a react wrapper) for creating a React class:

(defcomponent MyClass
  (foo [this]
    ,,,)

  ^:static (bar [this] ,,,))

I could imagine like:

(defclass MyClass :extends SomeOtherClass
  ,,,)

@lilactown this is the exact syntax I was also thinking!

or MyClass :implements SomeInterface

For this line:

(.val (js/jQuery (str "delivery" (:num-delivery-addresses db))) (:description suggestion))

I'm getting the following error:

Uncaught Error: [object Object] is not ISeqable
    at Object.cljs$core$seq [as seq] (core.cljs:1226)
    at re_frame$fx$do_fx_after (fx.cljc:74)
    at Object.re_frame$interceptor$invoke_interceptor_fn [as invoke_interceptor_fn] (interceptor.cljc:71)
    at Object.re_frame$interceptor$invoke_interceptors [as invoke_interceptors] (interceptor.cljc:109)
    at Object.re_frame$interceptor$execute [as execute] (interceptor.cljc:204)
    at Object.re_frame$events$handle [as handle] (events.cljc:65)
    at Object.eval [as re_frame$router$IEventQueue$_process_1st_event_in_queue$arity$1] (router.cljc:179)
    at Object.eval [as re_frame$router$IEventQueue$_run_queue$arity$1] (router.cljc:198)
    at eval (router.cljc:146)
    at Object.eval [as re_frame$router$IEventQueue$_fsm_trigger$arity$3] (router.cljc:169)

hello, anyone here?

This is in an event handler btw

@pshar10 can you verify your brackets? looks like (:description suggestion) is the context object jquery is expecting

Yeah that expression is a string

pretty sure

@flyboarder

?

@pshar10 is your db an atom?

I don't know what that means

like not a data-structure you mean?

you might need to add @db if the db object is an atom containing your map

i dont know much about your app so I am guessing at what the vars could be

it's a map you get in as a parameter in re-frame, if you're familiar with it

the simple thing to do would be to replace it bit by bit

for all intents and purposes it's a parameter of a function, and within the function db is used

and figure out exactly which function is throwing

what does not ISequable mean anyway?

either :num-delivery-addresses or :description is operating on an object

not on a collection

so it’s attempting to access a js object as if it was a map

Yeah but both expressions actually give strings so they are valid

are you able to print each of these in-place of what is currently broken?

yeah that's why I'm pretty sure that they're valid

are you able to print the element you are selecting also?

there might be a difference between cljs and js strings though and the expression expects js ones, I don't know

well right now we dont know if (js/jQuery (str "delivery" (:num-delivery-addresses db)) <- this is broken

or if this is broken -> (.val elem (:description suggestion))

(js/jQuery (str "delivery" (:num-delivery-addresses db)))

ok so it’s probably (:num-delivery-addresses db) try deref’ing the db (:num-delivery-addresses @db)

if this db map is in an atom it will need to come out first

no it's not dereference-able

hm, im at a loss then, what happens when you print the db is it a straight clojure map?

The expression is valid but I think it's in the wrong place or something. That reframe expects some other ending to that function, I don't know.

yes it's a regular map

what is it contained within?

I'll check out #re-frae

#re-frame

The default implementation of weakmap doesn't make a lot of sense in CLJS, right? As in, it works on identity, and not value. Is it true to say that underneath the hood, cljs doesn't try to "reuse" objects that have already been created with a particular value...? Hence, there's no way for a weakmap to know if a particular instance of a value can be discarded or not.

It makes sense if identity is important to you, which it might in some

CLJS will generally allocate a new object anytime you use a data literal

So a value added to a weak map, might be garbage collected and removed from the weak map if you lose reference to that object

(def ws (js/WeakSet.))
=> #'cljs.user/ws
(.add ws :hi)
=> #object[WeakSet [object WeakSet]]
(.has ws :hi)
=> false

yup 😞 it gets funky.

(def k :hi)
=> #'cljs.user/k
(.add ws k)
=> #object[WeakSet [object WeakSet]]
(.has ws k)
=> true

@dazld all the JS collections only operate on object identity and in development keywords are recreated on time. in a release build you'd get the "expected" result since keywords are only created once.

Is there any good library support to traverse the DOM? The particular use-case I have is react-testing-library and accessing node collections, childrens, attributes and so on. The JS interop works, of course, but feels somewhat cumbersome.

@schaueho (tree-seq #(some? (.-children %)) #(array-seq (.-children %)) js/document)

tree-seq is like, 33% of the reason I love ClojureScript 😛