What's a recommended library for routing using re-frame (`reagent`)? I'm looking for a simple solution and an active library

reitit is a good one

do you have an example of how to combine those two?

re-frame and reitit

@itaied check https://github.com/ingesolvoll/kee-frame

@itaied The reitit examples are pretty good https://github.com/metosin/reitit/tree/master/examples/frontend-re-frame

Does anyone have experience with writing externs for monkey patched/object extended functions? I'm trying to use a React HOC (`stripe-react-elements`) that takes a component you define and returns it with functions extended onto it. I'm running into issues then calling those functions (i.e. mycomponent.monkeyPatchedFunction) with advanced compilation. I'm not super experience wrt react/re-frame/cljs in general so apologizes if this is poorly phrased. It almost seems like maybe the extern should be from the perspective of my component rather than the library itself?

This is the extension in particular I'm trying to extern: https://github.com/stripe/react-stripe-elements/blob/master/src/components/inject.js#L97

@ianbishop you only need to create externs for code you write. the best way to go about that is using :infer-externs and just adding a small typehint to prevent the renaming of a given thing

@thheller Ah ok, I think I've conflated the two a bit since I also generated cljsjs externs for the lib. I'll take a look at doing that. Thanks!

Someone faced this warning before? I think because of this my re-frame routing functions did not work

react-dom.inc.js:11632 Warning: componentWillMount has been renamed, and is not recommended for use. See  for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder. 

I am surprised that CLJS's clojure.core/min doesn't behave identically to JS's Math.min. Math.min(0, null) → 0 but (min 0 nil) → nil. I am guessing I shouldn't file a bug?

I’m more surprised it doesn’t act like clj, since it results in a nullpointerexception there

I'm not terribly upset about that, since ClojureScript says CLJS nil → JS null, and in JS null will gladly turn into a number for you.

@dale min is a numeric function and requires numeric arguments. Passing non-numeric arguments leads to undefined behavior.