in the past i've used defprotocol to override clj-http / cljs-http functions. it's been a while, but maybe i can dig up some code.

To override you mean that the first variable in your functions was a http which implements a Http protocol. Is that so?

I think I will do the same

(defn get-products
  [^Http http
   {:keys [results search-string]
    :or {results 5
         search-string "water"}}]

yeah, something like this (but not entirely)

(defprotocol Http
  (GET    [this url params])
  (POST   [this url params])
  (PUT    [this url params])
  (DELETE [this url params]))

(defn do-http [http method url params]
  (case method
    :get (GET http url params)
    :post (POST http url params)
    :delete (DELETE http url params)
    :put (PUT http url params)
    (GET http url params)))

can't find a working example at the moment 😉

Looks perfect!

Thank you!

🙃

@U0GC1C09L Btw can I implement only a part of a protocol in Clojure/script? Or do I have to specify implementation for all of methods in Protocol?

i guess neither? i remember only implementing functions that i wanted to override depending on the context (dev / test).

but i'm not an expert in the matter!

(deftype ActualHttp []
  Http
  (GET [this url params]
    (http/get url params))
  (POST [this url params]
    (http/post url params))
  (DELETE [this url params]
    :delete-not-implemented)
  (PUT [this url params]
    :put-not-implemented))

i guess you could chuck in a test flag somewhere and dispatch a real or mock request

@U0GC1C09L I tried to reify Http Protocol in test namespace but I’m unable to do it. 😮 I received an error about calling the function of undefined. But when I try to reify in the same namespace then everythin works like a charm

(defprotocol Http
  "Abstraction over http requests"
  (get [this url opts] "GET http request"))

(get
 (reify Http
   (get [this url opts] (println "Hello")))
 "Hello" {})

just curious -- are you testing on the jvm or a (headless?) browser?

admittedly i've never had the need to reify anything

Well I don’t know which one is used by figwheel main. I quess that it’s done by JVM

but the results are indeed in the browser

that's beyond my knowledge. 🙂 last time i checked though, clj-http was not browser compatible, and cljs-http was not JVM compatible. that's probably just a tangent but you never know.

in a previous project i differentiated between clj and cljs: https://github.com/intermine/imcljs/blob/dev/src/clj/imcljs/internal/io.clj#L2 https://github.com/intermine/imcljs/blob/dev/src/cljs/imcljs/internal/io.cljs#L2

Hmm. Now I’m talking about regular protocols in Clojurescript. I defined a simple protocol in one namespace

(defprotocol Http
  "Abstraction over http requests"
  (get [this url opts] "GET http request"))

(deftype http []
  Http
  (get [this url opts]
    (println "Hello")))

(get (http.) "" {})

#object[TypeError TypeError: (intermediate value).get is not a function]
	 (<NO_SOURCE_FILE>)

@U0GC1C09L it should work for you https://stackoverflow.com/questions/31641030/call-clojurescript-from-javascript

cheers! but that's what i'm already doing: ^:export

Btw how do you try to require your function?

ah jeez, i wasn't calling it via its nested namespace. my bad.

someproject.core.myfunction();
"abcdefg"

😄

Happy that I could help

much appreciated!

FWIW, ^:export doesn't really preserve the function name. All it does is make a non-minified name that points to the original function.