am I going crazy? i thought you could have a my-ns.core that’s my_ns/core.clj as well as a my_ns/core.cljs and it’s totally fine? for example, if I wanted to do this:

(ns my-other-ns.core
  (:require [my-ns.core :refer-macros [some-macro]]))

My understanding is we cannot require .clj from cljs file. So your code may not find proper macro…

@lwhorton try doing (:require-macros [my-ns.core :refer [some-macro]])

How do I do npm deps with cljs10?

I want to simply try out loading react and react-dom per npm-deps

It did work with the previous cljs 1.9 release

Now it appears that the process shim is broken somehow

The compiler emits production code for react-dom. That invokes react-doms mysterious checkDCE function that breaks everything.

I had to set :process-shim explicitly to true (doc says its set true by default but at least with -r it isn't)

But even though in runtime process.env.NODE_ENV is "development", the compiler has emitted the production stuff and react-dom won't load

I have disabled aot-cache

Or are there new requirements

how to use npm deps ?

@leongrapenthin it sounds like you’re talking about an issue specific to React

many libs are not going to consider that env var and this isn’t really a problem

but I can’t offer any more real information, I tested with a bunch of other libs, but not React recently

@dnolen Well it worked with the last stable 1.9. Also my brief debugging session indicated that :process-shim simply doesn't work as it did before anymore. It is not enabled by default, and it appears to set NODE_ENV to "production" during code emission and to "development" only later. So should I file a ticket or repro this?

a ticket with precise information is best

react-dom/index.js has this line "if (process.env.NODE_ENV === 'production') {"

for anything Node module process related unless you know exactly what is wrong

it’s not worth describing

it is eliminated and the code for the true case is emitted

ok

but even better, if you can discover what’s wrong, just supply a patch

:)) will look into it later today

@leongrapenthin process shim stuff is all in cljs.closure, but if you what you says is true you should also just try to set the :closure-defines yourself

the process shim ns exists so that this can be done

along with preventing React from breaking as it expects it

ClojureScript 1.10.238 is released https://clojurescript.org/news/2018-03-26-release

That clojurescript commandline is pretty slick, good stuff!

Does anyone use material-ui-next?

I have a strange issue. Cursor jumps to the end of the atom-powered textfield each time I edit it.

And it only happens on mui text field

@achikin I had similar issues, you could try using :default-value instead of :value

oh nvm, I don't think that solves your issue

yeah, I figured 😕

@benzap it kind of solves the issue, but now there is some issue with reactive deref

Those inputs use the same atom but mui one does not react to atom changes any more

think it's because :defaultValue just sets the init-state within the input element, and then leaves it unmanaged

I couldn't figure out why the mui input field acted like that either, i'm using it within rum. I'm guessing you're using reagent?

Yes, its reagent.

Do you have the same issue with rum?

yeah, I believe it's similar

I'm curious about how you're wrapping the TextField to work in your code?

Is that some sort of adaptive thing that reagent does?

I ended writing my own adapter code for all of my material-ui stuff

adapt-react-class

It's a usual way to wrap React component to work with Reagent

ah ok

@achikin Check https://github.com/madvas/cljs-react-material-ui/issues/17 it shows some workarounds (best workaround would require Reagent change)

Tried to use npm library by :npm-deps. I add :npm-deps {"react" "16.2.0" "react-dom" "16.2.0" "create-react-class" "15.6.3" } to cljsbuild compiler option. But there is this code

if (process.env.NODE_ENV === 'production') {
// DCE check should happen before ReactDOM bundle executes so that
// DevTools can report bad minification during injection.
checkDCE();
module.exports = require('./cjs/react-dom.production.min.js');
} else {
module.exports = require('./cjs/react-dom.development.js');
}

The value of process.env.NODE_ENV is "development". Does not know why closure compiled version treat the if clause as true?

Does it need some additional config to make the npm-deps work?

@dumeng81 @leongrapenthin duplicate report

but still not enough information

we only set “production” if optimization is not :none

see cljs.closure/add-implicit-options

yeah, setting :closure-defines {"NODE_ENV" "development"} doesn't do it unfortunately

{:npm-deps {:react "16.2.0"
                                      :react-dom "16.2.0"
                                      :create-react-class "15.6.3"}
                           :externs ["process.js"]
                           :main "hello-npm.core"
                           :output-to "resources/public/main.js"
                           :output-dir "resources/public/js/out"
                           :asset-path "js/out"
                           :optimizations :none}}

@leongrapenthin that isn’t how :closure-defines works

fully qualified

like I said go look at cljs.closure/add-implicit-options and see for yourself

and fix this for yourself if somehow it is wrong 🙂

https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/closure.clj#L2216

I'm running Cljs 1.10.238 + Reagent 0.8-alpha2 with Node modules and it is working for me.

it doesn't work with explicitly setting :closure-defines {"process.env/NODE_ENV" "development"} either

very strange that the compiler emits the production clause

Oh right, the error is from Chrome React Developer Tools

I don't usually have that enabled so haven't seen this error

If you check process.env.NODE_ENV on browser, it is correctly set to development

It is just that the React 16 CommonJS bundle is completely insane

@juhoteperi can confirm that disabling dev tools does the trick

React 15 would also work

nonetheless if you compare react-dom/index.js from the node_modules folder with the node_modules folder in the compiler output it makes no sense

This is Closure-compiler bug: https://github.com/google/closure-compiler/issues/2841

the call to checkDCE should never be emitted

This problem is not related to process.env at all

is it only since 1.10 because closure compiler has been updated?

Yes

@juhoteperi Thanks for all the clarification.

and also @dnolen for helping invalidate my theory quickly 🙂

Hi! Any help with this please? https://clojurians.slack.com/archives/C053AK3F9/p1522072000000173

it’s found at the indexed location there under https://repo1.maven.org/maven2/org/clojure/clojurescript/1.10.238/

however, that error sounds like it might be related to security. I’m curious what version of Java you have installed (`java -version`)

@alexmiller we followed up in #beginners

it was Java 9, but I’ve never seen that

I’m running Java 9 by default

I have seen people report this, but I don’t remember why

things to check: use -Sforce to ensure you don’t have any classpath cached, see if this works if you go via leiningen dep, check whether you have anything funky in your Maven ~/.m2/settings.xml

@alexmiller Weird. After reinstalling 9 -> 8 -> 9, it works with jdk 9 too now. And I did wiped .m2, and the local .cpcache and ./out

hard to tell which one of those was important :)

Right

Well, enough to move on for me now. @alexmiller thanks!

going through the new clojurescript guide. 😍

Looks like there's a lot of new information (or maybe I'd just missed it before) about using npm dependencies and stuff.

No new information really, we need to do some updates in fact

Finished the quick start guide.

Super easy to get up and running. Much faster than the old days, no hiccups.

And TTFX went from 0 to ?. 😄

Thanks for the feedback!

Hello guys, is there an alternative for Redux Offline on Cljs? Or just a good guide to PWAs?

You could try re-frame and follow their guide.

No luck, didn’t found it

https://speakerdeck.com/gja/progressive-web-apps-in-clojure-script

This has some codes to leverage the cache issues

Anyone know of any good shopping sites (perhaps with code available) written in Clojure?

With respect to everyone involved. Is their a difference between lumo and clj for the purposes of creating a executable node js file. Both aim to produce a js executable, right?

@drewverlee Most notable difference is that lumo uses self hosted clojurescript and lets you execute scripts without setting up a project. So it’s very suited for one off scripts.

Of course clj with cljs.main lets you do the same now, but the startup time is longer

and you require a JVM, which is not all that bad though, but for a little script it can be too much

@drewverlee another thing to add for js transpilation is that the Closure compiler port to JS is not completely the mirror of the JVM one. YMMV

Question: Is there anything like babel/coffee-script translator for CLJS? like: https://babeljs.io/repl/

@quang You can try KLIPSE: http://app.klipse.tech/

I guess the question is "What are you trying to achieve?"

sweet thanks @borkdude exactly what I was looking for.

just trying to get use to JS interop syntax

Cool. Another alternative is to use Lumo or Planck with -v, which will cause them to print out the JavaScript for any form you enter. Or use any REPL in :repl-verbose mode http://blog.fikesfarm.com/posts/2015-06-15-see-js-in-cljs-repl.html

Thanks @mfikes I'll check those out.

hey is (.format(js/moment)) no space after .format, proper? or is that considered bad style?

Another example showing how trivial it now is to put a REPL in verbose mode is at the very bottom of https://clojurescript.org/news/2018-03-26-clojurescript-command-line

(.format(js/moment)) would normally be written as (.format (js/moment))

The first form seems to kind-of imply that you are calling format with an argument of js/moment

But really it is evaluating a call (js/moment) and then passing that as the first argument to .format

Likewise, you'd put a space in (str(js/Date.)) and instead write (str (js/Date.))

I'm surprised (js/moment"2018") doesn't throw an error...

tempted to save the extra space... but something is telling me that's a bad idea...

Hah. You will make a lot of developers pause and wonder about code like that 🙂

I'm liking the terseness of Clojure... why wouldn't that be a good idea?

By the way, since you are looking into JavaScript interop, there is a draft guide that hasn't yet been published, might be useful https://github.com/mobileink/clojurescript-site/blob/88805681e76a86dcab068ec8b574ed733ebd5f8c/content/reference/javascript-interop-ref.adoc

(js/moment"2018") is a bad idea because, even though I work on the ClojureScript compiler, to be honest, I would have to try such an expression to see if it is even handled properly 🙂

nice @mfikes Thanks for that link!

I mean, I guess we should all immediately know if (js/moment"2018") is well formed, but, life is short 🙂

We need an interop reference page on the site

> I would have to try such an expression to see if it is even handled properly hmm :thinking_face: yeah I'm surprised it compiles... but I guess that might change in the future? it seems like it should throw an error

Yean @dnolen I think we just need to wrap up the draft. It is too useful to not have 🙂

http://www.spacjer.com/blog/2014/09/12/clojurescript-javascript-interop/ - was the best I guide I found before @mfikes’s link

Well, the semantics of (js/moment"2018") are probably well defined, but I suspect if you try to elide spaces around lots of code, you might find things that don't work as expected. For example, I think this used to work in very old versions of Clojure: (#(str%1) 1)

if moment("2018") is correct from the console, then (js/moment "2018") would be valid. what’s wrong with it, despite the deprecation warning you’ll get from this library?

If I had to guess, @quang is curious about eliding unnecessary spaces from code.

That wip page is a bit too much and cover stuff we don’t want to cover, we just need a minimal page with the basics

I used to go to http://himera.heroku.com/ for a cheatsheet on js interop, but it’s down

Me too

http://cljs.info/cheatsheet/ is alive though

That would match the conciseness David mentioned. We should get the Heroku examples, which were to-the-point and useful.

you can still run this locally: https://github.com/fogus/himera

hsts 😞

Another thing that I don't think is documented is the Math pseudo-namespace.

fyi I guess (js/moment2018) would definitely not work as wanted (passing a number), so I guess it's better to always add that space...

IMHO, whitespace formatting in Clojure has never really been an issue. It is mostly about where to choose to put forms on new lines that are getting a little long.

In other words, it truly does become difficult to discern who wrote a bit of code because it is so uniform.

(You know, you've worked on projects in other languages where you can just tell by the style, who on the team wrote that code 🙂 )

I can still recognize who of my colleagues wrote what usually 😉

I can only tell Nathan Marz's code. Otherwise it all looks the same to me. 🙂

Elm has a nice philosophy on that, they use whatever whitespace that's causes less diff's

> Goal: a consistent style that is easy to read and produces clean diffs. http://elm-lang.org/docs/style-guide

Well, sometimes I think: who wrote that.. and magit-blame tells me I did… 😛

(not= (f'x) (f 'x)) as well... space it is...

Golang is super fun with diffs on Github. All those super wide 8-space “tab only” indentations.

I think you can fix it a bit with ?ts=2 on the URLs for github, but there’s no way I know of to make that persistent.

I can identify one coworker by 3 or 5-space tabs. 😬

I’m using doo and phantomjs for my cljs unit tests and my test diffs are really hard to read. Are there any tools that can pretty print the result and maybe even highlight the what’s different?

I managed to get pjstadig.humane-test-output to work for pretty print

It does the diff too

I’m using promesa with some Node code on AWS, and I’m suddenly getting “Should be only used in alet macro.” errors, which should be catching uses of await outside of alet. But all mine are within alets - does anyone have any idea why that might happen?

@cfleming I know that go blocks can’t traverse function boundaries and the promesa docs say it is using go machinery, so I wonder if that’s your problem?

@lee.justin.m Interesting, I hadn’t considered that. But there’s nothing in the doc or the docstring to suggest that sort of restriction around its use.

I would be shocked, shocked I say, to learn the a clojurescript library docstring was anything less than comprehensive. 🙂

Ahhhahaha

However this did previously work for me, so something odd has changed. Perhaps a clean build is in order.

(not this exact code, but using alet in the way I’m using it now).

and i could be wrong. although i’ve looked at the promesa library many times, i haven’t yet tried it

When it works, it’s really lovely.

There has to be a better way than what core.async is doing right now, so maybe I’ll try it.

Also, to be fair to the funcool guys, their doc is usually excellent.

Yeah, I like it better than core.async, especially for code which is really emulating synchronous calls (like AWS)

This is what I was referring to, fwiw: https://github.com/clojure/core.async/wiki/Go-Block-Best-Practices#unsupported-constructs-and-other-limitations-in-go-blocks

Right. The problem is I don’t know how much of the core.async stuff is being used - an alet is always contained within a single function, but I don’t know if there are restrictions on functions which call it.

it seems like it would be very hard to do. even in javascript, async/await can’t cross function boundaries. you have to redeclare an async function and await it