Anyone know how to generate externs for https://raw.githubusercontent.com/dreyescat/react-rating/master/lib/react-rating.js I copy paste the link in http://jmmk.github.io/javascript-externs-generator/ but it doesn’t load anything

oh, with this link it is working: http://dreyescat.github.io/react-rating/lib/react-rating.js

Would you know what is the JavaScript object to enter for this lib?

when does it make sense to reimplement a js lib as a cljs lib? I'm looking at the polymer source at https://github.com/Polymer/polymer and I'm thinking it would not be all that difficult to make a pure clojurescript version. But other than advanced optimization and namespaces, I'm not sure what that would buy us.

Is it a true statement that for any CLJS interop form like (.method <object> <params>), method must be on an object prototype?

i.e. it must be like some.ns.MyObject.prototype.method = function() {etc etc}

I guess the other case is if you explicitly assign a function to an object instance and then call it, but it seems like that would be uncommon.

@cfleming not a true statement, nor a good assumption

under Node.js:

cljs.user=> (def path (js/require "path"))
#'cljs.user/path
cljs.user=> (.resolve path ".")
"/Users/anmonteiro/Documents/github/clojurescript"
cljs.user=>

How is the path object defined, though?

I guess that’s a module, right?

path is the exports of a module

How would resolve be defined in the JS code?

you can think of it as an object

something like

function resolve(){
...
}

module.exports = {
  resolve: resolve
}

Hmm, I see.

This is in the context of completion, BTW, just trying to figure out where I should be looking for candidates.

Lumo has very basic support for JS completions: https://github.com/anmonteiro/lumo/blob/master/src/js/lumo.js#L269

I’ve been planning to try to understand the JS module system better, I might have to now.

granted, this is under Node. So I don’t need to worry about anything else 🙂

And works by talking to the live system, correct?

yeah

Sadly, I can’t do that.

ah right. the SDK thing

Ok, thanks - I’ll check out the module system stuff.

More the static analysis thing.

perhaps this is not the best way to start

I guess if this is for Cursive & ClojureScript nailing down goog stuff & foreign lib would be more approachable?

Yes, definitely more important.

I think I have most of that working now.

@cfleming and for foreign libs that have externs you have a lot of work done for you

Exactly.

They tend to define functions like Object.prototype.method = function() {}

So all that is fairly straightforward.

exciting stuff

I’m not a Cursive user myself but I know a handful of people that will be very happy with that support 🙂

Actually all that works (to some degree) in Cursive now, I’m just improving the performance, and working on better test coverage.

gotcha

At some point soon I’ll attempt type inference too, which is very helpful in Clojure. There’s less information in CLJS though, but I still expect it to be useful.

I notice that on a def, the :file metadata is an absolute path, unlike in clojure where it is a path relative to the classpath. Is there any reason for this?

So happy to see @cfleming in this channel 🙂

@grav I always lurk here 🙂

Haha, well seems like you’re doing more than lurking, and that can only mean good things for Cursive’s cljs-story 🙂

Definitely! Lots to come 🙂

Great to hear!

@thheller I'm trying to use shadow-cljs to write a node module. It works with (cljs/once :my-id) but when using (cljs/watch :my-id)or (cljs/dev :my-id) I got this error: clojure.lang.ExceptionInfo: missing instance

@myguidingstar oh oops, these currently assume to have the embedded server running (which the shadow-cljs CLI command launches). you can launch it manually by calling (shadow.cljs.devtools.server/start!)

I see. Thanks

only need to start it once per JVM

it works. Thanks a lot @thheller

shadow-cljs is great

thx 🙂

cljs has no clojure.string/re-quote-replacement?

@isaac you can probably use goog.string.regExpEscape

does not, looks like it relied on a Java thing so it wasn’t ported

@moxaj that really good, thanks

@dnolen IMO, define an alias re-quote-replacement in clojure.string of cljs has better uniform with clojure

@isaac what do you mean?

(btw I’m not suggesting it shouldn’t be ported if it can be done simply, just explaining why it’s not there)

if ported it to cljs.string, the cljc file writing more convenient

I just got started on Clojurescript and trying out my first hello world. How can I add bootstrap to project created using https://github.com/reagent-project/reagent-template

@isaac the cljc doesn’t seem essential here

would also tie development of that ns to Clojure dev timeline - do not want that

(I might be misunderstanding what you are suggesting)

@dnolen I think he just wants feature parity regarding re-quote-replacement, no special stuff

oh right - yeah so misunderstood

@dnolen I mean, we need not use conditional read in code like belowing, if we ported?

(defn foo [s]
  #?(:clj (str/re-quote-replacement s)
     :cljs (gstr/regExpEscape s)))

@isaac yes sorry I understand now

someone should make an issue and suggest that patch but also outline where the behavior diverges so we can provide an accurate docstring to set expecations

I would pleasure do, 🙂

@dnolen I created [CLJS-2165](https://dev.clojure.org/jira/browse/CLJS-2165) for this feature.

@isaac thank you!

Looks like the clojure 1.9 uri? predicate is missing from cljs

@rickmoynihan yeah would probably need to tie to Closure Uri type

@dnolen: cool: https://dev.clojure.org/jira/browse/CLJS-2166

cool Closure Compiler change: https://github.com/google/closure-compiler/commit/4735d982d81d763b6a1887460152bc6d8b8052fb

I’ve seen people have problems with Google Analytics & advanced compilation

^ this will be in the next ClojureScript release

nice

so, since searching has failed me (somehow), does anyone have a good cljs client-side approach to making a button that exports a table to csv?

the key part being cross-browser support (including like IE9+) where it downloads a generated file

The creating of the actual CSV part isn’t something that really needs much assistance. This cross-browser supported, client-side download a generated file part seems to be problematic via searches. I haven’t found anything in about it with respect to cljs or google closure though, so making sure I wasn’t missing anything out there

I think I’ll probably just end up doing it server-side to avoid the drama

@mikerod We ended up using the download attribute on the link, but that’s not IE compatible at all. Alternatively you can send the Content-Disposition header, but since you cannot control the header in an <a href=, you need to do an XHR request.

No wait a moment, that’s not true. The server needs to send the Content-Disposition header in the reply. That should be cross-browser as far as I know.

At some point we experimented with using XHR and embedding the download-file in a link, but I forget why 🙂 Might be because it’s a way to ensure download without having control over the server. I’m afraid I don’t have any code, nor do I have good search terms for googling it