It's been a very long time since I've had to deploy cljs and I'm (rather oddly) having trouble getting all the js to compile to one file, i.e. without needing a dependency on goog. The project.clj is from a figwheel template, but I'm using cljsbuild and have :optimizations set to :advanced so not sure what's going wrong. Any ideas?

Hi #clojurescript do you have examples of distributing a clojurescript library as a regular javascript library?

what kind of library? for the browser or node?

only ones I know of are https://github.com/swannodette/mori and https://github.com/tonsky/datascript

Nice I'll look into these, thanks @thheller

it isn’t very practical to publish libraries like that since they all include cljs.core by themselves and cannot share it

so they get larger than typical js libs otherwise would be

But there's no better way, right? Since cljs use the closure goog.require, it'll break with other packaging/import system?

:advanced compiled code doesn’t contain goog.require anymore but yes

closure wants to optimize your whole program, which includes all the libraries you use

that doesn’t work too well if you want to just ship a library

if you want to build a lib for node you can use

https://github.com/thheller/shadow-cljs/wiki/ClojureScript-for-node.js-libraries

in theory this can be used for browsers but I don’t think its a good idea to do so

@roman01la then that’s contradictory to what you said earlier

there’s just no way to accomplish what you want unless you want to go bootstrapped

hi, does anyone has an idea on how to import a scoped npm package in clojurescript? I tried something like "{:npm-deps {:@dp/whatever "2.0.10"..." but failed with the message "java.lang.RuntimeException: Invalid token: :"

And it fails even when I use something like "(keyword "@dp/whatever") "2.0.10"..."

@chrisdavies @metametadata @shaunlebron I use ‘humane-test-output‘ for prettifying my test output, works well

@curlyfry I wasn't able to get it to play nice with cljs.test, but I must have been configuring it improperly.

Do you have a sample project.clj where you've configured it?

(Oh, and thanks! :)

@thheller Could shadow cljs rewrite something like new cljs.core.Keyword(...) to cljs.core.keyword_intern?

@rauh why would it? it rewrites to cljs$cst$keyword$… and only allocates once?

basically :optimize-constants?

@thheller Yeah, but if I create one at runtime with the same name I have two keyword instances. I can't get the global constant in any way.

but no there is no generic rewrite facility in place

Hmm I see, I'd have to hack on the emitter. Kinda don't wanna do that.

yeah should still be easier than writing a closure compiler pass to do it 😛

@rauh whats the state of weak refs in JS engines? maybe we can default to interning at some point

looks decent enough http://kangax.github.io/compat-table/es6/#test-WeakMap (if accurate)

Still no-go, even with the Weak Sets/Maps. I'd like an option in cljs but it'd def be big undertaking. For browser JS I don't need any weak refs since there is no attack vector. Only really needed for server side JS.

all it would take is a simple change in the compiler to not emit new cljs.core.Keyword but actually calling the keyword fn

then you could replace that fn and be done

maybe a special keyword fn so the pre-hash works

Yeah, I could also hack the deftype and replace it with real constructor. But it's too hacky.

IIRC its a simple change though

https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/compiler.cljc#L268

just replace that fn 😉

Yeah I know, but I kinda wanted to stay out of cljs.compiler namespace changes

yeah it isn’t pretty but I do it in some places

it works well enough

but it works in

Planck 2.5.0
ClojureScript 1.9.562

Lumo 1.5.0
ClojureScript 1.9.542

caching it was!! but of old devtools 😢