Yeah just doesn't exist in 178

It could only come from older version

super cool http://blog.fikesfarm.com/posts/2015-11-14-try-clojurescript-parallel-compilation.html

After a few years working on a compiler heavily based on immutability, David says, “I've got some time to kill. I know—I'll throw in a couple of fns to parallelize the whole shebang.” :)

Nobody knows the answer to my q?

@dnolen: what happens if eg there are 8 cores & 9 or more deps earlier than a common ns in the queue? Deadlock? Also, even if full deadlock doesn't occur there could be wasted opportunity for the blocked agents who could be working on ns further into the queue whose deps are already resolved.

@johanatan: can’t happen, already topologically sorted

as far as wasted opportunity yes this could be true, would need something that actually partitions distinct significant subtrees of work.

but my hunch is that it will probably be wash and improvements beyond this will be much more incremental.

in the end 30%-50% speed bump across a large spectrum of contemporary hardware for 20-30 lines of code is a clear victory

@dnolen: ahh, cool. Ya, totally

@dnolen: there may be a simple solution to the wasted opportunity tho: like a priority queue of sub trees

Or just a skip list over the various largish chunks of tree

@johanatan: sure but I’m not gonna to work on this any more though It’s now clear where this logic can go and we’ll happily take enhancement patches.

(well not work on it beyond error reporting issues for the current implementation anyway)

to answer my question re: deep prop gets/sets: aget and aset do accept multiple levels. Unfortunately I could find nothing better than (aset "the" "props" (clj->js (merge (js->clj (aget "the" "props")) {:new :props}))) for doing the merge / property update/addition.

there's https://github.com/purnam/purnam if you need a lot of interop

interop? Lol

Cool, I'll consider that if these things grow too much

@johanatan: aget and aset really isn’t for dealing with Objects, see goog.object

Can we assume that “public" functions in cljs.core which are not in clojure.core are not implementation details? I’m thinking particularly of random-uuid. This function is cljs only and I’m not sure if it’s to be considered part of the public API?

https://twitter.com/mfikes/status/665909244525420545

@jonas: random-uuid is public

Why do I get "goog.require could not find: cljs.core$macros" with :whitespace optimization, and not with :none? Also, I don't think I'm even using that namespace ...

@dnolen I know it’s public, that’s why I’m asking. I have previously considered all functions that exists both in clojure and cljs as set in stone (thanks to http://clojure.github.io/clojure/). Since cljs doesn’t have a separate api documentation it’s difficult to know what’s part of the public api and won’t change/be removed in future versions.

@jonas: I don’t remember the last time we removed something public from ClojureScript

cljs.core/format

is about it

we don’t remove things randomly and we never will

That’s nice to hear, thanks!

There’s an obvious advantage in having the two (clj and cljs) apis as much as possible the same.. so perhaps we can push for having random-uuid in clojure.core as well?

@jonas: sure I would talk to @alexmiller about that

@mfikes just tweaked the parallel build stuff, feel free to test

@dnolen: Awesome… will do!

added proper error handling

this stuff should be good to go for the next release

(Damn. Too much awesomeness surrounding ClojureScript today to keep up with.)

@mfikes: thanks for putting together the independent ns example

my suspicion is that the parallel stuff really takes off for bigger projects that have independent nses like that

@dnolen: Yes, my activity monitor shows 100% vs 2000%, so I think that there is about 20x the work being done… something fishy I’d like to understand...

there might also be some small heuristic to implement here that give more consistent behavior across a wide variety of project structures

something to think about

still we have a nice clean way to introduce such enhancements with little affect on anything else

@dnolen: I tested with your “error handling” patch. My iOS project didn’t break when recompiled with it, and the fith-postulate test runs properly (at the same speed as previously). My CPU is actually running around 2200% and 2300%—its using all the cores so I want a 24x speedup. Gonna have to dig into that mystery.

Might just be I/O bound?

@mfikes could you do me a favor and run lein cljsbuild once parallel a second time (without clean)?

my machine isn't capable of handling your crazy setup

@thheller: Sure….

well .. it is still running after about 30min 😛

@thheller: A second time without clean appears to work properly (it finishes quickly)

@mfikes I'm interested in the time

didn't expect any breakage

$ time lein cljsbuild once parallel
Compiling ClojureScript...

real	0m8.770s
user	0m39.605s
sys	0m2.806s

for non-cold builds I’ve seen that we lose a lot of time on reading EDN

@mfikes thanks

will probably investigate switch to transit for analysis caches

I expect we can cut non-cold build time w/ zero changes by >10X

@dnolen I'm aware of a couple of bugs related to caching ... but not excatly sure how/where to report them

since the scenarios to trigger them are rather complex

but everytime someone is told "did you try lein clean?"

that is a manifestation of such a bug

yeah we need minimal cases

to me that is unacceptable

well the minimal case involves at least leiningen

there’s also a whole class of low hanging fruit around aborted builds

and you don't like that

not going to look at anything involving lein for this problem

lein is not the issue

dependencies are

then you should be able to repro trivially without lein

well yeah but the step by step gets much more confusing

I haven’t personally seen issues with caching in a very long time

the only cases I’m aware of, user changes dependency version or aborted build

yeah changing a dependency is the trigger

but that should still not require a lein clean ever ...

With debug-prn I can see that it plows through blocks of 20 or so namespaces at a time owing to them all being the same size. This gist shows that behavior, with me manually adding newlines between each chunk or wave: https://gist.github.com/mfikes/32efc0c717b141b6ea43

@thheller: then the steps to repro aren’t complicated are they?

we have logic for recompiling JARs that change but obviously something is wrong

yeah the issue is that it currently tries to determine whether a recompile is needed based off of one timestamp

that isn't accurate enough

need to account for the timestamp of all deps (eg. jars)

eg. you compile today with om alpha20, then update to alpha22 and compile again

since you compiled today .. last modified is today

but alpha22 was released yesterday

so no recompile is triggered

(reposting from the clojure channel, since there are more clojurescript peeps here) Hi. I'd like to deploy a reagent project to tomcat. I created a "lein new reagent myapp" project, then I added the lein-ring plugin. Then I "uberwar" and deploy. But I get the "ClojureScript has not been compiled!" message.... despite it being compiled during the "lein ring uberwar" What am I missing?

(no idea what actual om release dates are, just an example)

@thheller: sounds like a bug with cljs.closure/source-on-disk

not anything in cljs.analyzer or cljs.compiler

I have no idea where the bugs are just how to trigger them (since I fixed it in shadow-build) which was using the same logic requires-compilation? or requires-analysis?

a single timestamp is the issue

yeah those functions don’t matter

anything in JAR goes through source-on-disk

and that logic won’t copy out fresh stuff to disk

you misunderstand

well ... maybe .. dunno what sources-on-disk does

but if it preserves the date of the jar

@thheller: you misunderstand that I understand what you are saying

and that bug is present in source-on-disk

which is what copies stuff out of JARs

but why is copying files out of a JAR important?

ah it copies with a new date

because if we fix source-on-disk the bug just goes away

hmm no that seems to already compare the date

ah ok got it

https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/closure.clj#L1509

well, that would fix a part of the issue since it doesn't account for macro changes

but probably unlikely that a macro changes without the cljs changing

http://dev.clojure.org/jira/browse/CLJS-1487

excellent, I could not think of a simple description of the issue

Hey, anyone knows why I get "goog.require could not find cljs.core$macros" if I have [cljs.js :refer [eval js-eval empty-state]] in my ns require? Works with :none optimizations, but fails with :whitespace (compiles without warnings, but I get the error message when loading the document).

hey, anybody know if it’s possible to get figwheel to refresh when i change a non-cljs/css file? i am editing a plain js file and it would be awesome to have my reload-fn triggered on changes

https://github.com/bhauman/lein-figwheel/issues/46

https://github.com/bhauman/lein-figwheel/issues/284

How do I get a CLJS repl running in cursive? I don't need any reloading into a browser, I just want to be able to evaluate code for library development. Maybe this is a question for #C0744GXCJ... sorry just noticed that channel

Jmmk, I think there is a REPL execution configuation

you just create one, then run it

thank you @danielcompton. figured it out, am thoroughly enjoying it