clojure.edn/read-string uses *data-readers* right? I'm getting "No reader function for tag time/zoned-date-time" even though time/zoned-date-time => #'time-literals.data-readers/zoned-date-time is in *data-readers*

@robert.mather.rmm you can provide data readers as an optional argument, otherwise only the default data readers are used, according to the doc string of edn/read

I'm trying to figure out if it uses the default readers vs. the ones explicitly passed, not certain yet https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/EdnReader.java

fwiw that java file has no reference to *data-readers* that it would grab, and the value also isn't passed in by clojure.edn/read

Thanks. Passing explicitly via the :readers opt worked. I was just surprised *data-readers*` wasn't used. What's that for, if not the built-in reading mechanisms? Does it only get used for core/read not edn/read?

precisely that

see notes here https://clojuredocs.org/clojure.edn/read and here https://clojuredocs.org/clojure.core/*data-readers*

I guess that makes some sense due to the safety issues around core/read

I think this summarizes the behaviors and workaround

(ins)user=> (println (slurp "src/data_readers.clj"))
{foo/bar clojure.core/set}

nil
(cmd)user=> #foo/bar[1 2 3]
#{1 3 2}
(ins)user=> (read-string "#foo/bar[4 5 6]")
#{4 6 5}
(cmd)user=> (clojure.edn/read-string "#foo/bar[1 2 3]")
Execution error at user/eval154 (REPL:1).
No reader function for tag foo/bar
(cmd)user=> (clojure.edn/read-string {:readers *data-readers*} "#foo/bar[1 2 3]")
#{1 3 2}

clojure-lsp uses org.eclipse.lsp4j and has a single java file

@JsonSegment("clojure")
public class ClojureExtensions {
	@JsonRequest
  @SuppressWarnings("unchecked")
	CompletableFuture<String> dependencyContents(TextDocumentIdentifier documentUri) {
    IFn require = Clojure.var("clojure.core", "require");
    require.invoke(Clojure.read("clojure-lsp.main"));
    IFn extension = Clojure.var("clojure-lsp.main", "extension");
    return (CompletableFuture<String>) extension.invoke("dependencyContents", documentUri);

this causes in target/

├── classes
│   ├── clojure_lsp
│   │   └── ClojureExtensions.class
│   └── org
│       └── eclipse
│           └── lsp4j
│               └── TextDocumentIdentifier.class

:cause class "org.eclipse.lsp4j.TextDocumentIdentifier"'s signer information does not match signer information of other classes in the same package

This problem seems to only happen on java > 8. Can anyone point me in a direction to understand why this TextDocumentIdentifier is being compiled? Removing this class file prevents the security error

I misunderstood, that is a weird one

i think i have solved it with -implicit:none as a javac option but i don't know if i'm solving the root issue or solving a symptom

I wonder if there is something in the deps tree for lsp4j that is including the Java source that you could exclude. I have this vague idea that lsp4j is using eclispe's custom Java syntax thing, and the tooling for that somehow ends up including Java source in jars, and then lein's use of the javax tools javac results in a compiler that looks for source anywhere on the classpath, which results in compiling that class. But I don't know for sure about most of that. And I am not sure if that explains why just that one class is compiled.

still digesting what you wrote but yes its using xtend, the sugar over java language

that one class is the only one imported into the java file in lsp. i've been trying other java classes and no other ones end up in the output so your theory is a good starting point for me

another thought. java looks for class files and source files, by default preferring whichever is newer. if the java source file is an artifact due to the sugared language, it might be older than the class file and therefore javac thinks it needs a newer version and compiles it again?

whoops /s/older/newer

Yeah, the question is where is the source coming from, and can it be excluded

the source is in the jar unfortunately

:dependencies [[org.clojure/clojure "1.10.0"]
                 [jarohen/chord "0.8.1"]
                 [cljs-ajax "0.8.0"]]

[jarohen/chord "0.8.1"] -> [com.cognitect/transit-clj "0.8.275"]
 overrides
[cljs-ajax "0.8.0"] -> [com.cognitect/transit-clj "0.8.309"]

Please help me understand why my solution to problem http://www.4clojure.com/problem/39 works in the REPL but fails when pasted on to the site:

(fn f39
  [s1 s2]
  (-> (zipmap s1 s2)
      (seq)
      (flatten)))

They want you to provide just the fns, without def

It'll look like fn-x fn-y

Or #(...)

Sure I use fn, when I copy on to the site but still get "You failed the unit tests"

Yeah, not helpful at all

There might be some kind of implementation detail or unspoken deprecation.

You should take a close look into map doc

Yeah working on other implementations, was just wondering why this one doesn't work.

https://github.com/4clojure/4clojure/blob/develop/src/foreclojure/problems.clj#L196 here's the code for testing user input

https://github.com/4clojure/4clojure/blob/develop/src/foreclojure/data_set.clj#L428 here's the problem definition

Oh great thanks. Interesting but that exactly how i test the function in my REPL user> (= (f39 [1 2 3] [:a :b :c]) '(1 :a 2 :b 3 :c)) That returns true

They're using the jailed version, there might be some issues with it, idk

I've struggled myself with stuff like this a couple of times

Yeah, thanks for the hints

Just tried the source code of zipmap

(fn [keys vals]
  (loop [map {}
         ks (seq keys)
         vs (seq vals)]
      (if (and ks vs)
        (recur (assoc map (first ks) (first vs))
               (next ks)
               (next vs))
        (flatten (seq map)))))

No luck. But if I get rid of hash-map here

(fn [keys vals]
  (loop [ret []
         ks (seq keys)
         vs (seq vals)]
    (if (and ks vs)
      (recur (conj ret (first ks) (first vs))
             (next ks)
             (next vs))
      ret)))

Everything is ok

Looks like it fails when I'm trying to assoc to a hash-map

Don't know the reason though

Weird, on the android app, the unit tests pass, but sending to the server errors saying it rejected the solution

I wonder if zipmap isn't allowed but they forgot to mention it as a restriction just like interleave?

> I wonder if zipmap isn't allowed but they forgot to mention it as a restriction just like interleave? I've tried without zipmap, and it seems like the issue boils down to assoc with hash-map

It’s a super old clojure version and it’s possible some functions don’t exist there

But I think the problem is there’s a “flatten” in zipmap which I think might be lazy. Your repl will force evaluation of these (the P in repl) but running on 4clojure doesn’t

is it possible to build a syntax sugar like #:person[:id :name :age] ,just like the prefix for map with data_readers?

@doglooksgood no

okay, I just feel there are more and more time I'm writing [:a/x :a/y :a/z]

Is that for restructuring?

Destructuring?

I used core.logic to solve http://regexcrossword.com puzzles and wrote up what happened: https://www.lvh.io/posts/solving-regex-crosswords/ -- demo (if you're on linux amd64) here: https://github.com/lvh/regex-crossword/releases/tag/0.1.0