Fork me on GitHub
#clojure
<
2018-12-17
>
emccue00:12:59

I feel like im missing something that would explain this behaviour

tomjack00:12:04

(satisfies? B "foo")

emccue00:12:43

yep that was it

tomjack00:12:47

(extends? B String)

narendraj907:12:45

How does the special form var resolve private symbols? Is something else used for resolving symbols that are used directly?

alexyakushev07:12:27

When you call functions or refer to global definitions normally (like (somefn a b c)), the compiler first resolves them to Vars and then emits proper invocation code. And in the compiler there is a check that the function/variable being used is not private.

alexyakushev07:12:02

When you do (var somefn) it indeed resolves differently, and on that path there is no such check.

narendraj909:12:23

Okay. Both of the mechanisms have to use namespace objects to do the resolution right?

alexyakushev09:12:42

Either the symbol being resolved is namespace-qualified (then, that it will be looked up in that namespace), otherwise *ns* will be used.

orestis07:12:04

var resolves everything you give to it, including private symbols.

taylor16:12:22

I have an old project that has a transitive dependency (via Immutant) that seems to have disappeared from the internet in the past few days: org.projectodd:polyglot-cache:jar:1.20.0

taylor16:12:55

looks like it may have been hosted at https://repository-projectodd.forge.cloudbees.com/release which is now 404 ... anyone else seen this?

tcrawley16:12:01

@taylor I used to work on Immutant. I'll ping my old team to see if that cloudbees account has been shut down

taylor16:12:18

awesome, thanks!

tcrawley16:12:42

If it is indeed dead, I'll see if I can get those artifacts deployed to maven central

taylor16:12:20

thanks for your help

tcrawley19:12:08

I looked at deploying polyglot to central, but the polyglot build depends on artifacts that were in that cloudbees forge :(

taylor19:12:05

I'm currently tracking down and uploading all the missing deps to an internal repo. Looks like there were several missing deps besides polyglot too. FWIW this project is on Immutant 1.1.4

taylor19:12:37

just got my build passing again. Thanks for looking into this again

tcrawley20:12:23

Glad you got it figured out. Would you be willing to share a list of all of the artifacts you had to track down?

taylor20:12:50

org/projectodd/polyglot-cache/1.20.0 (POM + JAR)
org/projectodd/polyglot-modules-parent/1.20.0 (POM only)
org/projectodd/polyglot/1.20.0 (POM only)
org/jboss/as/jboss-as-parent/7.2.x.slim.incremental.16/ (POM only)

tcrawley20:12:39

Thanks! 7.2.x.slim.incremental.16 is what is preventing polyglot 1.20.0 from building for me

👍 4
alexmiller17:12:43

cloudbees just eol’ed some of their products this past weekend

jrychter17:12:15

I'm pondering the use of single-segment namespaces. In general, I know they are to be avoided. But as I'm moving to ns-qualified keys in all my data structures and as I'd like to use the :: reader syntax sugar, the keys in my data structures must correspond to namespaces. And I'm beginning to worry about the overhead — many extra characters per key are being stored in a database, exported, imported, moved over the wire, etc. I came here to listen for sage advice on the subject.

dustingetz20:12:10

My advice is to give up on auto-qualified data keywords. Basically, clojure package namespaces are for dependency tree-shaking, and data is global. So my current belief is that we cannot be using require and/or ns for data namespaces as there is no dependency graph. And unfortunately the auto-qualified keyword sugar is complected with these concerns, so we cannot use it from our data. This area I hope gets some design work in a future version of Clojure. Also note that the EDN reader doesn't understand auto-qualified symbols. Nor does Datomic

tomjack21:12:17

if you can find a design where there is some other context for keyword namespace aliases -- besides the Clojure ns -- maybe you could change the readers somehow...

tomjack21:12:39

I am starting to think that this context belongs at the RE{P,B}L

tomjack21:12:14

(don't change EDN, don't change clojure reader, just change the tools?)

jrychter21:12:35

@U09K620SG If you use spec (I do), you will still need to make sure the specs for your keywords are defined when you'd like to check them. A 1:1 mapping between data namespaces and Clojure namespaces helps with that.

dustingetz21:12:49

There are deeper issues in play, for example, namespaced keywords are universal (quoting conv with rich after the ions talk in nyc). That means a namespaced keyword is as good as a UUID and can be merged into a hashmap from some other universe without fear of collision. For this to be true, we would need some sort of resolution mechanism to route :db/ident's namespace :db to com.cognitect.datomic - e.g. a deps.edn for data

tomjack21:12:26

in my current fantasy, datomic would be patched to accept com.cognitect.datomic.db (or whatever), my files would contain that full namespace, but my tools would show me an abbreviation

dustingetz21:12:19

I like the idea of using the clojure reader for this, but complecting code packages with data packages is a problem

tomjack21:12:29

(though, I can still fantasize about tools without datomic being patched)

tomjack21:12:10

doing it in the reader seems wrong to me, after thinking about rich's message for 5 years 🙂

tomjack21:12:17

I considered the concept of a "nameplace" which we can declare and which collects namespace aliases, among other things. Then a Clojure ns has an associated nameplace, but this is just a special case. And some reader literal tag or something can be used to say "this data should be interpreted in that nameplace" (to deal with "object-at-a-time" in EDN)

tomjack21:12:34

but "nameplace" is not a word 🙂

dustingetz21:12:36

Can you give me an example of what the EDN should look like?

tomjack21:12:58

it shouldn't

tomjack21:12:04

that is wrong 🙂

tomjack21:12:36

for me though there is a question of how/whether/when tools should indicate abbreviation of the data on disk

dustingetz21:12:42

If the edn keyword namespaces are not aliased – which tooling layer do you mean this shoukd happen in?

tomjack21:12:56

editor, repl, etc

dustingetz21:12:17

Each tool needs to implement their own version of this?

tomjack21:12:40

there should be a convention for describing how to abbreviate by a data structure

dustingetz21:12:00

Alternately, if the EDN is assumed to be stored in datomic rather than text files, datomic query could be the tool with the sugar

tomjack21:12:10

hopefully parts of the code for actually doing it can be shared

tomjack22:12:24

I dunno, maybe there is something here the readers can do

tomjack22:12:05

if you have people writing .edn files in notepad who don't know they're using aliases, you have to do some weird things to be able to read anything while using aliases anywhere

tomjack22:12:51

e.g. read the edn with no handlers, walk the tree (and TaggedLiteral wrappers) doing the name translation you want, emit back to edn, read again with actual handlers

tomjack22:12:09

but I don't use notepad 🙂

tomjack22:12:31

(I suppose you don't need to emit back to EDN, you can just call the real handlers in a tree walk)

dustingetz22:12:41

this is crazy, but if all edn is stored in datomic, that means all edn has a schema. Lets also assume that spec and datomic schema are unified. Now any eav needs to be interpreted within the context of it's schema/spec, which means we need a registry from namespace to spec

tomjack22:12:09

I'm not sure what you mean about this because datomic doesn't even have an EDN value type 🙂

dustingetz22:12:27

and not a value type

dustingetz22:12:39

the attrs are already typed in datomic

dustingetz22:12:55

presumably that is eventually open to extension

dustingetz22:12:36

but all roads lead to any given edn blob needing to be interpreted relative to its spec

dustingetz22:12:55

which opens the door back to aliasing mechansim, resolvers, etc

tomjack22:12:02

datomic stores values/datoms/txs, not edn blobs

tomjack22:12:14

EDN is useful when we work with disks and wires for example

dustingetz22:12:34

datomic datoms become the universal protocol

dustingetz22:12:07

edn blob is isomorphic with datoms, it doesnt matter

dustingetz22:12:53

assuming the allowed value types are open to extension

dustingetz23:12:24

So you're kind of saying that, EDN is information and information is different from representation. It's the text/filesystem representation that needs sugar, which should be provided by the tool that renders the representation. In the pure form of data, the essence of it is always fully qualified and never ambiguous. That's why it belongs in the tooling layer. Do I understand?

tomjack23:12:10

I guess 🙂

tomjack23:12:14

btw, have you seen the reader resolver?

tomjack00:12:51

user> (binding [*reader-resolver* (reify clojure.lang.LispReader$Resolver
                                    (currentNS [_] (ns-name *ns*))
                                    (resolveVar [_ sym])
                                    (resolveAlias [_ sym]
                                      ('{blog 
                                         post }
                                       sym))
                                    (resolveClass [_ sym]))]
        (read-string "#::blog{:posts [#::post{:title \"post1\"} #::post{:title \"post2\"}]}"))
#:{:posts [#:{:title "post1"} #:{:title "post2"}]}

tomjack00:12:10

however it only resolves aliases in symbols when it needs to, when syntax quote is used...

dustingetz17:12:01

thanks i hadn't

Eccentric J17:12:32

Is it possible to invoke the clj CLI with multiple -m args?

alexmiller17:12:32

it’s possible to run a .clj script though that does anything you want

Eccentric J18:12:22

Ah thanks! In theory, I should be able to make a library that launches an nrepl server, setups up rebl-nrepl middleware, cider, and maybe rebel-readline and reference that library in deps.edn with a :main-opts to run it succinctly right?

chrisulloa17:12:23

Did anything change between 1.10-RC5 and 1.10?

chrisulloa17:12:52

Excellent thank you

eval202017:12:40

@jrychter both type of namespaces have separate concerns in my experience: whereas a ‘code namespace’ should never clash with any other library, data namespaces mostly don’t need that: {:video/id "YR5WdGrpoug"} is better than {:id "YR5WdGrpoug"}. I’ve also heard experiences that using :: turns renaming a namespace into a nightmare.

hiredman17:12:08

there are a lot of assumptions in the question about how data is going to be stored and transported as well

chrisulloa17:12:17

We’ve been using 1.10 in production for sometime now with the cognitect/aws-api and it’s been working great so far. Solved some illegal reflective access warnings on our upgrade to Java 11 from 8. Only thing that we had to change in our code were Java import statements (:import [java.util Date])) instead of (:import [java.util.Date]))

alexmiller17:12:59

yeah, the latter has never done anything and was never intended to be valid

chrisulloa17:12:42

Not a problem, was a simple fix for us. Better to be correct.

hiredman17:12:21

the "overhead" of keys in a database is largely going to depend on your database choice, and if you storing blobs of data in the database, or actually storing data in a way that the database can see

hiredman17:12:45

a sql database for example, usually already provides facilities for namespacing names (tables, schemas, etc)

hiredman17:12:48

(on top of the fact, of course, that sql databases don't store column names repeatedly like that anyway)

jrychter18:12:33

The overhead gets accumulated all over the place, and I'm beginning to get worried. Think of things like memory consumption on the ClojureScript side. It can be mitigated in some places (transit helps on the wire, for example), but overall it feels silly to add additional 9 characters to every key everywhere, unless there is a very good reason.

hiredman18:12:49

keywords(in clojure, and likely in clojurescript) are interned

jrychter18:12:08

@eval2020 Hmm, I'm not sure if using separate data namespaces is practical. I'd need to try it to be sure, but all spec examples assume your code namespaces correspond to your data namespaces and use the :: syntax.

hiredman18:12:21

:x/f is always an identical object to :x/f regardless of the source

hiredman18:12:09

using :: in examples is strictly to keep examples short, not because it is good practice

jrychter18:12:27

Hmm. The renaming effort is huge anyway, so I guess I might as well use separate "fictional" data namespaces and stop using the :: notation...

jrychter18:12:33

@eval2020 Yes, I did run into that. In most cases it turned out to be a signal for the need for code refactoring, but in certain cases it's unresolvable.

hiredman18:12:41

not only is it not required for keyword namespace names to match code namespace names, I think it is bad for them to do so

hiredman18:12:05

e.g. you don't name a database table after the code that touches it

hiredman18:12:28

data is data independent of the code that manipulates it

jrychter18:12:13

Right — but you lose the slightly nicer syntax, then. But I guess it's a reasonable price to pay.

hiredman18:12:29

the nicer syntax leads to brittle code too

hiredman18:12:44

you copy and paste code from one namespace to another then boom

eval202018:12:16

I agree with hiredman: detach data ns-es from code.

jrychter18:12:00

Thank you for your time and advice — I am now looking at this closely and trying it out. Well, trying will take 2-3 days with the size of my codebase.

4
trevor18:12:47

What's the landscape look like in 2018 if I want to develop a REST API using spec? I've seen compojure-api but are there any other libraries?

trevor18:12:35

BTW, it doesn't have to be ring/compojure based

ikitommi18:12:36

@trevor check out https://github.com/metosin/reitit. Works with ring, pedestal/interceptors and frontend.

👍 4
trevor18:12:33

What would the difference be between reitit and compojure-api since I see a lot of similarities between the two

ikitommi19:12:42

compojure-api is a concise, opinionated and monolithic macro-based dsl for the backend, #reitit is a data-driven, modular and open tool for end2end routing. Reitit has mostly all the features of c-api (and more). Concise vs Composable.

kardan19:12:06

Been playing a little with Reitit to get to know it and been impressed.

Eccentric J20:12:44

I wrote a small luminus web app with +reitit +re-frame for work. It was a really enjoyable experience once the concept of data-driven routing clicked. Especially when you see the same routing library used in cljs as clj and knowing you could easily share routes between them.

trevor21:12:48

I'm definitely for anything that's data based especially routing. I guess I'll need to do some small prototypes to see which routing library best fits my needs

Eccentric J18:12:36

How would one transform the string "#'user/msg" to the unevaluated literal #'user/msg?

Eccentric J18:12:27

(read-string "#'user/msg") -> (var user/msg) which is not quite what I want

hiredman18:12:47

your repl is just being weird

hiredman18:12:16

(var user/msg) is a synonym for #'user/msg

hiredman18:12:27

(I assum you meant var there not val)

Eccentric J18:12:23

Oh, good catch. Also I’ll try it but I’m working on some tooling middleware for nrepl so being able to show it as the target is actually important.

hiredman18:12:28

you are using clojure.edn/read-string

hiredman18:12:13

and the synonym of var and #' is only after evaluation

Eccentric J18:12:11

Wait sorry, this is a moot problem now. The issue corrects itself when switching from nrepl “0.4.5” to “0.5.3". 😓

macrobartfast19:12:27

I use clojars in emacs to find deps ( M-x clojars), sometimes, but don't always find what I'm looking for... in the current moment clojure.java.jdbc... are any of you able to pull it up that way... is there a better approach? I might be misusing the package... dunno.

tcrawley19:12:00

all of the clojure contrib libraries are deployed to Maven Central, not Clojars

macrobartfast19:12:34

ah ok... so is there a way to find them from emacs? got used to the M-x clojars approach... or... how do you do it?

macrobartfast19:12:22

I also have seen several tools for adding the most recent dep version numbers if you type type the base name into your project.clj... but I usually get mixed up about when to use dot and / separators and have to look them up. #maybe-being-just-too-lazy

macrobartfast19:12:05

ok... the maven central site is pretty slick... that will work (although something from an editor would rock).

macrobartfast19:12:48

I feel like it would be great if we had an npm style tool you could search and add things to project.clj... as it is I flounder around on clojars, maven, etc and am never sure if I have a current version or not and it's a bit of a buzzkill when you're trying out deps. I'm sure it's all part of the adaptability of clojure which I may need to understand more.

macrobartfast19:12:15

I remember lein plz... I'll give that a go.

ikitommi19:12:42

compojure-api is a concise, opinionated and monolithic macro-based dsl for the backend, #reitit is a data-driven, modular and open tool for end2end routing. Reitit has mostly all the features of c-api (and more). Concise vs Composable.

lmergen20:12:57

there’s also ataraxy if you like data-driven routing

cupello20:12:16

Hi guys! I comming back to clojure and I would like to know if is there a good alternative to Intelij IDE?

dpsutton20:12:21

many people are happy with emacs + CIDER or VS code + calva, in addition to the cursive plugin for Intellij

👍 4
dpsutton20:12:14

no problem. there are channels for each if you have questions

dpsutton20:12:22

#calva-dev #cider

dustingetz20:12:10

My advice is to give up on auto-qualified data keywords. Basically, clojure package namespaces are for dependency tree-shaking, and data is global. So my current belief is that we cannot be using require and/or ns for data namespaces as there is no dependency graph. And unfortunately the auto-qualified keyword sugar is complected with these concerns, so we cannot use it from our data. This area I hope gets some design work in a future version of Clojure. Also note that the EDN reader doesn't understand auto-qualified symbols. Nor does Datomic

alexmiller21:12:48

I’m still working on the 1.10 clj release

alexmiller21:12:31

technically, you can use any Clojure version, including 1.10, with the current version of clj, so it’s not really that important - it just affects your default if you don’t have a deps.edn

kommen21:12:53

ok, I was just about to update our docker images where we use the linux installer to install the default version and noticed this

alexmiller21:12:08

brew pr is still pending for mac

kommen21:12:54

thank you, much appreciated

Eccentric J21:12:43

Awesome, thanks!

aaelony22:12:10

Hi - my understanding is that Clojure 1.10 has been released. Does a release apply to brew upgrade clojure on a mac?

aaelony22:12:16

$ brew upgrade clojure
Error: clojure 1.9.0.397 already installed

dpsutton22:12:12

@aaelony from above. it is pending

aaelony22:12:23

ah - thank-you.

alexmiller22:12:35

you don’t need an updated brew formula to use 1.10 though

aaelony22:12:41

understood

alexmiller22:12:52

just add org.clojure/clojure {:mvn/version "1.10.0"} to your deps.edn to use it

alexmiller22:12:18

pr is https://github.com/Homebrew/homebrew-core/pull/35199 - brew prs seem to be backed up at the moment

alexmiller22:12:34

often takes 12-24 hrs to go through anyways

aaelony22:12:53

related question… I’m am very familiar with lein new myproject but about to try the deps.edn approach for the first time. Is https://clojure.org/guides/deps_and_cli the best resource? Is there a tool that does something analogous to lein new myproject?

alexmiller22:12:02

there is

👍 4
alexmiller22:12:18

specifically clj-new

aaelony22:12:33

awesome, I’ll read through it. Thank-you

alexmiller22:12:40

although the “template” for a deps.edn project involves almost nothing, so I do not find it to be necessary

aaelony22:12:35

my goal is to migrate off an amazonica project to com.cognitect.aws… I haven’t experimented with deps.edn before however

alexmiller22:12:16

cool, feel free to ask questions in #aws if you get stuck - David watches that

aaelony22:12:24

excellent. thanks

aaelony22:12:22

should

clj -Sdeps '{:deps
              {seancorfield/clj-new
                {:mvn/version "0.5.5"}}}' \
  -m clj-new.create \
  app \
  myname/myapp 
just work out-of-the-box? I get a long stacktrace with no “caused by” clause

seancorfield23:12:54

@aaelony It should just work, yes:

(! 507)-> mkdir aaelony

Mon Dec 17 15:17:08
(sean)-(jobs:0)-(~/clojure)
(! 508)-> cd aaelony/

Mon Dec 17 15:17:10
(sean)-(jobs:0)-(~/clojure/aaelony)
(! 509)-> clj -Sdeps '{:deps
>               {seancorfield/clj-new
>                 {:mvn/version "0.5.5"}}}' \
>   -m clj-new.create \
>   app \
>   myname/myapp 
Downloading: seancorfield/clj-new/0.5.5/clj-new-0.5.5.pom from 
Downloading: seancorfield/clj-new/0.5.5/clj-new-0.5.5.jar from 
Generating a project called myapp based on the 'app' template.

aaelony23:12:34

@seancorfield, I filed a ticket. It doesn’t work as above for me

andy.fingerhut23:12:41

I don't know if it matters, but you have backslash at the end of most of the lines, but not the first two

Eccentric J23:12:48

As of yet, there is no means to attach rebel-readline to an nrepl server right?

hiredman23:12:30

attaching it to an nrepl server doesn't make sense

Eccentric J23:12:54

Could you please explain why?

hiredman23:12:17

readline is a user interaction facility

hiredman23:12:21

nrepl is client/server

dominicm23:12:40

Rebel could be a client.

hiredman23:12:45

the server doesn't interact with users

dominicm23:12:47

I disagree, I think it does make sense.

hiredman23:12:51

the server interacts with clients

dominicm23:12:04

Why couldn't rebel be a client?

hiredman23:12:31

then it would be just another client speaking the nrepl protocol

dominicm23:12:49

Yes, and...? 😁

Eccentric J23:12:52

Then that means it could be run within a client?

dominicm23:12:10

It would convert user interaction to client?

hiredman23:12:32

nrepl server <-> nrepl client <-> readline

Eccentric J23:12:13

Ok, thanks for breaking it down. Say I’m writing a small util to automate my repl experience. I’ve started an nrepl server and would like to start an interactive repl with it.

Eccentric J23:12:50

Sounds like I need to connect to the server as a client and then inject the (rebel-readline/-main)

dominicm23:12:00

For now, yes

dominicm23:12:25

Rebel is extensible though. A nrepl client is feasible

Eccentric J23:12:41

Ok, thanks for clarifying.

Eccentric J23:12:06

I found this but after trying it I noticed they weren’t really speaking to each other https://gist.github.com/jmingtan/3886fd0ad6da53100f6c59be651c755d

Eccentric J00:12:07

Wait, I was wrong. They are speaking to each other!

aaelony23:12:44

@andy.fingerhut - I literally just copy pasted the example from the “Getting Started” part of the readme

andy.fingerhut23:12:02

What OS are you using?

andy.fingerhut23:12:33

got it. Looks like Sean may have diagnosed the root cause there.

seancorfield23:12:53

It's an error in one of your existing deps.edn files.

aaelony23:12:39

I have no deps.edn… I’m seeking a skeleton like lein new myproject that yields a skeleton from nothing

dpsutton23:12:07

you you run clj and get a repl?

hiredman23:12:09

check clj -Sdescribe

seancorfield23:12:49

The stacktrace shows that tools.deps hits EOF while trying to read your existing deps.edn files. Either your system deps.edn file (unlikely) or your ~/.clojure/deps.edn file -- likely, if you've edited it.

aaelony23:12:58

looks like my clj is no longer working. It had been working before via brew

aaelony23:12:59

There may be some versioning issues…

$ brew install clojure
Warning: clojure 1.9.0.397 is already installed and up-to-date
To reinstall 1.9.0.397, run `brew reinstall clojure
`

aaelony23:12:16

yeah - clojure installs fine via brew, but the clj command just stacktraces

seancorfield23:12:00

Does rlwrap work at the command line? That should be the only difference between clojure and clj.

seancorfield23:12:35

Also, check that the clj command you're picking up actually is the one from the CLI install -- you might have an old, unrelated clj command on your path?

aaelony23:12:56

first time trying to use clj

seancorfield23:12:05

(! 510)-> which clj
/usr/local/bin/clj

Mon Dec 17 15:34:42
(sean)-(jobs:0)-(~/clojure/aaelony)
(! 511)-> which clojure
/usr/local/bin/clojure

Mon Dec 17 15:34:46
(sean)-(jobs:0)-(~/clojure/aaelony)
(! 512)-> which rlwrap
/opt/local/bin/rlwrap

aaelony23:12:56

I am removing it and re-starting with brew install

4
aaelony23:12:50

interestingly,

brew remove clojure
brew install clojure 
gives me a clj exectuable that stacktraces
Error building classpath. EOF while reading 
$ which clj
/usr/local/bin/clj 

aaelony23:12:26

macOS High Sierra Version 10.13.6

aaelony23:12:08

back to lein for now…

seancorfield23:12:43

What does clojure -Sdescribe show?

aaelony23:12:05

a long stacktrace

seancorfield23:12:08

(this is just checking whether it's just your clj script that is broken or clojure as well)

aaelony23:12:35

not sure… is there a way to be sure all artifacts are gone (nothing cached) ?

seancorfield23:12:52

Folks in #tools-deps would probably be keen to help you debug this as it should all "Just Work".

aaelony23:12:01

all in one line doesn’t appear to help

alexyakushev23:12:21

What does anyone think about this?

user=> (defn send-rockets! [] (println "BOOM!"))
#'user/send-rockets!
user=> (comment {:a} (send-rockets!))
Syntax error reading source at (REPL:1:14).
Map literal must contain an even number of forms
BOOM!
nil
Syntax error reading source at (REPL:1:31).
Unmatched delimiter: )

hiredman23:12:21

that behavior will depend on your repl

hiredman23:12:20

but in generally it is going to be hard to define a repl that does the right thing there

hiredman23:12:58

what repl are you using?

alexyakushev23:12:09

Figured as much. Would you say that such behavior is not set in stone, and custom REPLs are free to choose different behavior in such case?

hiredman23:12:27

that behavior is due to treating the input as a stream

alexyakushev23:12:48

This works the same in clj, rebel-readline, and nREPL

hiredman23:12:17

I am surprised that it does that in nrepl, what nrepl client?

hiredman23:12:05

but basically, because the input is malformed, it isn't like there is an easy way to determine where the malformed "form" ends

hiredman23:12:17

so it isn't like you can just skip past it in the stream

alexyakushev23:12:22

CIDER, but I guess that doesn't depend on the client, it seems like a default "eval" op behavior

hiredman23:12:38

it would depend on the nrepl client

hiredman23:12:46

because nrepl isn't stream based

alexyakushev23:12:09

Yep, so the form is sent in one message wholesale

hiredman23:12:41

hrrm, yeah, even from nrepl it would be tricky

hiredman23:12:21

the "right" thing there would be to skip all that input, but doing that is tricky

hiredman23:12:29

because the case for processing input is like a combination of completed form and newline

alexyakushev23:12:11

What's even more jarring is that this makes it harder to debug a stray odd-element map in the code since the actual cause gets obscured by totally weird and unrelated errors.

hiredman23:12:46

so don't use (comment ...)

hiredman23:12:39

and don't have top level effects

alexyakushev23:12:46

comment was just an example how a syntax error causes Clojure REPL to go execute things it had no business executing at that particular invocation; and it also produces alien error messages.

(defn foo [a b]
  (let [c {:a a :bb}]
    (println "Inside defn, why would I be called during compilation?")
    c))

             clojure.lang.ExceptionInfo: 
clojure.lang.LispReader$ReaderException: java.lang.RuntimeException: Map literal must contain an even number of forms
             java.lang.RuntimeException: Map literal must contain an even number of forms
             clojure.lang.ExceptionInfo: 
clojure.lang.LispReader$ReaderException: java.lang.RuntimeException: Unmatched delimiter: ]
             java.lang.RuntimeException: Unmatched delimiter: ]
Inside defn, why would I be called during compilation?
clojure.lang.Compiler$CompilerException: Syntax error compiling at (script.clj:246:1).
             java.lang.RuntimeException: Unable to resolve symbol: c in this context
             clojure.lang.ExceptionInfo: 
clojure.lang.LispReader$ReaderException: java.lang.RuntimeException: Unmatched delimiter: )
             java.lang.RuntimeException: Unmatched delimiter: )
             clojure.lang.ExceptionInfo: 
clojure.lang.LispReader$ReaderException: java.lang.RuntimeException: Unmatched delimiter: )
             java.lang.RuntimeException: Unmatched delimiter: )

alexyakushev23:12:16

I get how this is a limitation of stream-based REPLs, but in the different case I'd say this should be avoided.

dustingetz23:12:28

it didnt evaluate it, it parsed it

dustingetz23:12:53

use ; comments if you dont want it to be parsed

alexyakushev23:12:00

> Inside defn, why would I be called during compilation?

dustingetz23:12:12

it is a parse error, not a compile error

dustingetz23:12:29

it is an invalid s expression in clojure

alexyakushev23:12:44

... which means it's perfectly reasonable to execute random parts of that invalid S-expression? I don't get what you trying to say.

dustingetz23:12:58

it is not being executed, it is being read

dustingetz23:12:09

REPL stands for Read Eval Print Loop. This is Read phase

hiredman23:12:10

it is being executed

alexyakushev23:12:16

No, it is being executed, because println triggers.

hiredman23:12:25

what is happening is the parser throws an error

hiredman23:12:31

the error is reported

hiredman23:12:40

then the repl goes back to the top of the repl loop

hiredman23:12:47

and reads from the input stream again

dustingetz23:12:05

oh, isee, that is wild, i am wrong

hiredman23:12:19

and the input stream's state is pointing at to the place just after where the error occurred

hiredman23:12:58

but a strategy to pass over malformed input is really hard, because by definition it is malformed

dustingetz23:12:15

File a ticket if you want

alexmiller23:12:28

No, don’t as this isn’t going change

alexyakushev23:12:30

@alexmiller Yup, I get that. Just trying to figure out if it makes sense to try to push such change to nREPL since it's message-oriented, and it seems easier to skip over the invalid input there.

alexyakushev23:12:48

Thanks for everyone's response, I will brew it in my head for a while longer.