Fork me on GitHub
#clojure-uk
<
2017-05-17
>
reborg07:05:11

Regarding subseq the other day, I personally never used it, because I have limited use case already for sorted maps/sets. It appears that it was included in core after this discussion (2008) https://groups.google.com/d/msg/clojure/lJyubAhdPTk/9YSnBfBkJZMJ

agile_geek07:05:32

Hire from the North of England!

thomas07:05:12

morning 😼 mogge

thomas07:05:20

Style question for you folks.... We use Cucumber(-jvm) for testing purposes and we had a discussion regarding style of the Cucumber code...

thomas07:05:07

I wrote something like this: Given a valid IP address and then in the Java code I hardcode the IP address (the one I know to be valid)

thomas07:05:35

one of my colleagues prefers this style: Given that IP from x.x.x.x to y.y.y.y are valid And I use IP z.z.z.z ....

thomas07:05:36

so one hides the implementation details and the other exposes it.

thomas07:05:42

What would you prefer?

agile_geek09:05:45

Probably the second but TBH not precious about it.

glenjamin09:05:45

I’d prefer the first

glenjamin09:05:13

But it’s more important to ask the “non-technical” audience of cucumber tests

thomas09:05:22

@glenjamin that was my thinking as well.. the target audience isn't the techies... so therefore it is ok to hide implementation details.

dominicm09:05:34

I don't think you want to specify what an ip is in a test.

glenjamin09:05:00

unless your business owner cares about IP addresses like that

thomas10:05:06

I don't think they do... they care whether it is valid or not... that is what matters here (IMHO)

chrjs11:05:18

Second @agile_geek’s hiring recommendation.

agile_geek11:05:56

@thomas I was making the assumption that the 'owner' cared about the IP addresses or at least the QA ppl building the tests wanted to be able to see the detail of what 'valid' meant but as I said it's a bit horses for courses and it's not that hard to change.

glenjamin11:05:21

you could go ask them? 😄

thomas11:05:56

one of the devs here thinks that we should be more explicite.... I am not so sure myself....

thomas11:05:04

but I'll ask the customer tomorrow!!!

thomas11:05:58

(which is the maybe the weirdest part of this job... I have seen the actual customer more often in the last 6 months compared to 17 years of IBM)

mccraigmccraig11:05:47

developers talking to actual customers @thomas ! what kind of hippy outfit are you working for ?

thomas11:05:22

I know.. shocking.. shocking... my mother warned me about this!!!!

thomas11:05:21

at IBM the customer some kind of magical entity that was mentioned from time to time... but hardly ever observed in the wild.