Fork me on GitHub
#clojure-spec
<
2021-04-23
>
danm10:04:24

Yeah, that's what we've ended up doing. Ta 🙂

Alex Whitt15:04:02

in spec-alpha-2, will selects be composable? Assuming the answer is "yes," what does that look like?

👀 3
alexmiller16:04:53

I think the answer will be no, actually, but it depends what you mean. which part are you looking to compose?

Aron16:04:54

Personally, on the frontend the concept of static views that can define a select from the global state of the UI, then combining all of these into a single one for the whole of the UI?

Alex Whitt16:04:26

We have a data structure that is going to accumulate keys as it moves through our system. To model that, it would make sense to have a selection for "phase 1," then a "phase 2" that takes phase 1 and adds a few keys, and a phase 3 that builds on phase 2, and so on. It would be nice to keep that DRY. (Actually we have a data model DSL that generates our specs, so we could always do the composition at that layer, but I wanted to know what spec-2 was planning on supporting.)

Alex Whitt16:04:29

I guess I should've phrased my question as "are selections mergeable"

alexmiller16:04:52

I think that's a very interesting and unresolved question

alexmiller16:04:40

it depends somewhat on whether you see merge as an operation that produces an intersectional spec or whether it acts as parallel filters through which a value must pass (which is closer to how it's implemented)

Alex Whitt16:04:14

Wouldn't the first option be better for generation?

alexmiller16:04:16

certainly the latter seems doable

borkdude16:04:21

are the args to select dynamic, i.e. can you merge those programmatically?

alexmiller16:04:57

for generation, this is not that different than s/and in that you need to generate something that "passes" both specs but it's probably more challenging here

Aron16:04:22

I remember having serious issues with json-schema based validation because json-schema can be async, that is remotely resolved, and circular

alexmiller16:04:29

in spec 2, all of the spec can be passed as data which makes it amenable to merging the specification as data

👍 3
Aron16:04:49

So merging there was only possible with serious limitations and strict conventions

alexmiller16:04:54

there are a couple different ways data-based specs can be created in spec 2, so you actually have several choices - custom ops with s/defop (think spec template with holes), symbolic forms as data, and specs represented as maps. all of those are implemented now (with some caveats that the map form is kind of a hack in a few spots that are likely to change)

Alex Whitt17:04:16

I was wondering if selection merging would be a first-class feature, but it sounds like I'll probably want to do the composition at the data model DSL layer. That will generate our specs, schemas, and selections. The implementation will be a lot cleaner with spec 2.