Fork me on GitHub
#clojure-spec
<
2020-01-08
>
kenny00:01:40

Has anyone written a version of spec2 select that works with spec1? Deciding to have keys required or optional for all use cases is so painful 😣

seancorfield00:01:20

@kenny Not sure what you mean by "works with spec1"? The two libraries use different registries so you cannot combine them (at least, not easily)

kenny00:01:47

I mean a macro for spec1 that imitates spec2's select.

kenny00:01:02

When using nested maps, spec1 doesn't let you change which keys in the nested map are required.

seancorfield00:01:05

That's exactly why Spec2 is coming -- that required/optional thing in Spec1 is painful 🙂

seancorfield00:01:58

In Spec1 that is complected and baked into how s/keys works. In Spec2 the set of keys and the requiredness are decomplected.

avi16:01:06

You know, it just occurred to me — this is going to make it hard to create an interop schema using spec — in other words, to fully describe a data structure that a system expects/requires, including the keys that are required in each map… I suppose we might need to write some new plumbing to create a schema based on some spec2 specs, with additional annotation, expectations, etc. :thinking_face:

seancorfield16:01:44

I'm not sure I follow. Spec 2 still let's you specify which keys are required, including nested keys. It just teases the two concepts apart.

avi17:01:01

Hmm for some reason I was thinking that the new schema function was designed solely for the case of defining function specs… but I haven’t looked super closely 😬

avi17:01:42

is it schema? or maybe I’m thinking about select — I should just review the docs :face_with_rolling_eyes: sorry

seancorfield17:01:47

schema defines the possible set of keys. select defines the required subset of a schema.

seancorfield17:01:29

Hence, decomplecting specifying requiredness from specifying possible 🙂

avi17:01:56

Sounds pretty exciting, honestly!

avi17:01:46

I just did a walkthrough of a pretty involved schema using spec1 with some members of my team who aren’t familiar with it, and they asked a bunch of questions that I answered with “not right now, but that’s coming in spec2”

seancorfield18:01:39

Yup, I'm looking forward to Spec2 becoming non-alpha and the "standard" way to work with Spec.

👍 1
seancorfield18:01:22

For a while, I had a branch at work tracking Spec2 but with the number of bugs and changes as it has evolved, it was proving a bit much trying to keep our codebase current on it... so I gave up a while back and we'll take another look once it is stable. I doubt we'll migrate, but we'll probably start using Spec2 for new code (and may convert old code over as we maintain it over time).

👍 1
kenny00:01:27

Ya. Was hoping for a workaround for now. It seems potentially possible to get it to work.

seancorfield00:01:49

I don't know if s/merge will let you override an all-optional s/keys with a subset of keys that are now marked required. Doesn't help you much with nesting I suspect.

seancorfield00:01:31

You could just start using Spec2 I suppose 🙂 But not for any production work as it's still changing a lot.

kenny00:01:25

It's gotta be production worthy unfortunately