Hi. Do predicates need to accept MapEntry arguments to be used with s/or? This predicate

(defn str-date-time? [v]
  (try
    (some? (f/parse (f/formatters :date-time) v))
    (catch IllegalArgumentException _
      false)))

Part of the value

  {:post/updated "2017-05-05T11:55:00.000Z", ...}

when conformed as

  [:str-date-time "2017-05-05T11:55:00.000Z"]

(s/def :post/updated (s/or :date-time ::tspec/date-time
                                             :str-date-time str-date-time?))

@hjrnunes That sounds like you're passing a conformed value into str-date-time?

Yes it does. But it's utterly puzzling. I'm merely calling s/valid? on a map

Does s/or conform values?

The result of s/or is a tagged pair, yes.

so, I should cater for this in the predicate?

No.

I need to see more of your specs to see where you're flowing a conformed value into that spec.

actually, I have the same result with string? or int?

Show the context.

yes, I'm trimming stuff down. Thanks for the help

Do you have s/and somewhere? That's often where a conformed value ends up flowing into another predicate.

Yes I do

(s/def :post/published (s/or :date-time ::tspec/date-time
                             :str-date-time str-date-time?)) ;; should be DateTime or :date-time format

(s/def :post/updated (s/or :date-time ::tspec/date-time
                           :str-date-time str-date-time?))  ;; should be DateTime or :date-time format


(s/def ::post-found (s/keys :req [:post/published
                                  :post/updated]))

(s/def :post/missing coll?)

(s/def ::post-missing (s/and ::post-found
                             (s/keys :req [:post/missing])))

You probably want s/merge not s/and there.

Hmm, perhaps. So the idea is to re-use ::post-found and add another key - which is what actually happens to the data

so s/merge is the right way then?

That's what s/merge is for -- to blend two s/keys specs.

I see, I read somewhere, the mailing list I think, that s/and would work. Perhaps it was in a previous version

Yep. That does it. Thank you very much!

BTW, I listened to the defn podcast you were on recently - very interesting! Best of luck and thanks for all the work!

s/and is specifically for flowing a conformed value into another spec. For example, you might s/and one s/keys-based spec and then a predicate that checks two keys have distinct values perhaps.

s/merge is for extending an s/keys-based spec with additional key specs -- like merge for maps.