that makes me glad I deprecated it 🙂 did you switch to (gen/fmap inc gen/nat), or something else?

For now we just switched to gen/nat to preserve the behavior but we will revisit that test and see what might happen if it ever generates zero. At least it is clear now!

I can assure you it generates zero quite often 🙂

That test should probably fail with zero (but it doesn't) 😕

computers are crazypants

pos-int and neg-int are highly misleading w.r.t. 0, and all five of them are misleading w.r.t. size; I think generators by default should generate a healthy range of things, and if you want to restrict yourself to small numbers you should have to be explicit

so it's basically entirely a naming issue

spose I could've also deprecate-renamed gen/ratio to gen/small-ratio

Are you actually planning to remove them at some point (a breaking change) or just "strongly discourage" their usage?

the latter

there's already another deprecated generator of that sort

I found 15 occurrences of "deprecated" in that file 🙂

(seven functions)

entirely for naming, apparently:

(def ^{:deprecated "0.6.0"}
  char-alpha-numeric
  "Deprecated - use char-alphanumeric instead.

  Generates alphanumeric characters."
  char-alphanumeric)

Naming is hard. I struggled with deprecation/breakage in clojure.java.jdbc and ended up breaking the API twice to get it consistent and idiomatic. With hindsight I would have done it differently.

yeah I've tried to figure out how to overhaul things so many times, and largely haven't