This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2018-03-08
Channels
- # aws (3)
- # beginners (126)
- # boot (19)
- # cider (31)
- # cljs-dev (324)
- # clojure (96)
- # clojure-boston (2)
- # clojure-denver (9)
- # clojure-dusseldorf (2)
- # clojure-greece (4)
- # clojure-italy (5)
- # clojure-losangeles (1)
- # clojure-spec (18)
- # clojure-uk (59)
- # clojurebridge (1)
- # clojurescript (184)
- # community-development (29)
- # cursive (2)
- # datascript (2)
- # datomic (5)
- # emacs (1)
- # figwheel (6)
- # fulcro (270)
- # hoplon (2)
- # jobs (1)
- # jobs-discuss (1)
- # keyboards (2)
- # leiningen (2)
- # london-clojurians (2)
- # luminus (10)
- # mount (1)
- # off-topic (26)
- # onyx (8)
- # other-languages (1)
- # parinfer (1)
- # protorepl (6)
- # re-frame (23)
- # reagent (61)
- # reitit (5)
- # shadow-cljs (100)
- # spacemacs (3)
- # sql (19)
- # unrepl (90)
- # vim (25)
If I found a lot of problems with indentation in spec source, what is the best chance of doing a successful pull-request?
Thanks, actually I am registered as a contributor. More like if the changes would be accepted in any form. Perhaps they don't consider it as a problem
I doubt it, it’s really hard to make a good argument about indentation
Got an example though?
Line 8 and 9 seems strange
Perhaps this also: https://github.com/clojure/spec.alpha/blob/739c1af56dae621aedf1bb282025a0d676eff713/src/main/clojure/clojure/spec/alpha.clj#L754
on the second one I don't see a problem at all
to be frank, indentation doesn't matter much in Clojure, so I doubt these sort of patches would ever make it through.
The style guides that do exist for Clojure are more opinions than actual rules, so it's fairly common to see changes in indent styles across projects.
Disclaimer, I know I cannot possible "win" this
The problem is that a lot of tools force indentation, parinfer for example. So diffs becomes problematic
This is kind of a problem with the tools, but I figure that Clojure would be better of with a standard like pep8
Mostly because indentation really doesn't matter that much. But a standard that enables linters and automatic formatters is valuable according to me
https://github.com/bbatsov/clojure-style-guide and usage of parinfer could eventually become a defacto standard
I highly recommend you to watch this video https://www.youtube.com/watch?v=1YCkOo5Y4Oo