Hi all! Is anyone else getting errors like Call to clojure.core/ns did not conform to spec? I'm working on a clj/s project and I want to use spec with reframe. I've tried the latest version of clojure (`1.9.0-alpha16`) and I get the aforementioned error. However, when I move the dependency to 1.9.0-alpha10 the error does not occur. Any idea for the change? BTW This is my first attempt at using a clojure alpha version, and I have many dependencies that may be incompatible (I feel that this is unlikely in this case, though correct me if I'm wrong). If needed I can provide more information.

The namespaces for spec just changed in alpha16 and cljs and other deps are not compatible with it

You might want to fall back to alpha15

I actually tried every alpha from 16 to 10, and 10 was the first one that worked.

What's the actual error you're getting?

Many libs had bad ns deps - most of those have been fixed and newer versions exist

I put a gist up: https://gist.github.com/JJ-Atkinson/a1d19e48d9440c2ca9f0bed219c8201f. How can I tell where the error is originating from? I see that it likely is from (onelog/core.clj:1:1), but I don't know where that is, (probably in timbre though, I'll see if I can bump that version up).

Onelog is part of ring apparently part of ring-middleware-logger. I'm currently using the latest of both. So, is the issue not with clojure itself, but with onelog? If that's the case, I'll see about a pull request/issue to them.

So, after crawling through the error message more thoroughly, it appears that onelog is using the syntax (ns ... (:import (com.something SomeClass))). Spec changed something about ns with -alpha11, and it was already reported to them https://github.com/pjlegato/onelog/issues/3. Thanks for the help!

Apologies as this has probably been asked a dozen times, but does clojurescript current support generators?

@drewverlee not that I know of, but generators tend to encourage a impure code. Most of what you would need generators for can be done with more functionally pure constructs like map, filter and for.

@alexmiller So if I want to use alpha16 and have cljs in my project I should wait for a compatibility patch or something similar?

@tbaldridge I think @drewverlee is referring to the test.check kind of generators, given that he's asking in here 🙂 @drewverlee test.check supports cljs at least, not sure if clojure.spec's wrapping of it works with cljs, though.

@danielcompton this was the source https://gist.github.com/thheller/738698dfff45280f4e004df1c46af4ba#file-problem-clj

With the announcement of spec moving to its own lib, I see that spec.alpha is under org.clojure, but nothing like org.clojure/clojurescript.spec.alpha? Has it not moved yet?

Not yet

alrighty, thanks

what’s a good example of adding validation on a macro?

what do you want to validate?

actually, might need to rethink this

I have a wrap-error macro that takes a map of context data and a body.

(defmacro wrap-error [args & body]
  (let [e (gensym 'e)]
    `(try ~@body
          (catch Exception ~e
            (log-error! ~e ~args)
            nil)
          (catch Error ~e
            (log-error! ~e ~args)
            nil))))

what context map?

you mean you want to validate args?

no way to do this without a macro?

you want to use spec to validate args? add a clause to your let?

sorry let me try a better explanation. I want people to use this macro like this:

(wrap-error {:some :data :a 1 :b 2} ...body...)

(wrap-error ...body...)

might be hard to distinguish at read-time though. i wonder if this has to be a run-time check (`(s/valid? map? args)`)