This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2023-01-26
Channels
- # aleph (9)
- # announcements (31)
- # babashka (23)
- # beginners (35)
- # biff (2)
- # calva (5)
- # cider (10)
- # clara (11)
- # clerk (114)
- # clj-kondo (18)
- # cljdoc (37)
- # clojars (7)
- # clojure (24)
- # clojure-austin (10)
- # clojure-europe (27)
- # clojure-nl (1)
- # clojure-norway (23)
- # clojure-uk (2)
- # clojurescript (18)
- # conjure (2)
- # core-async (6)
- # cursive (21)
- # datomic (3)
- # fulcro (15)
- # introduce-yourself (7)
- # lsp (32)
- # malli (57)
- # meander (5)
- # music (1)
- # nbb (2)
- # off-topic (17)
- # pathom (6)
- # rdf (4)
- # reagent (8)
- # releases (2)
- # shadow-cljs (4)
- # slack-help (23)
- # spacemacs (6)
- # tools-build (32)
When is it appropriate to pester someone about a PR? I received some feedback, fixed it quickly, and now I'm stuck waiting to see if the fixes are satisfactory 😕
That's one reason why we use a kind of "prior approval" of PRs: • "I think you should consider doing this and that, and with that in mind, I'll give a ✅ "
It's an OSS project and I couldn't implement all suggestions due to reasons, so this probably isn't an option
According to urgency I pester colleagues within hour(s), at most a day. OSS is different, and maintainers are very different. But if it has been couple days, I would kindly ask if they could approve...
How long did it take them to respond to the PR in the first place with requests for changes? I would probably consider that to be their "cycle time" and wait at most twice that then ping the PR for additional feedback...
I tend to forget to respond to OSS PRs every now and then, and appreciate a reminder. I think that using exponential back off would be a nice strategy if multiple reminders are needed.
@UK0810AQ2 I think it's appropriate to send a reminder in a PR after a week or so? Everyone can forget
@U04V15CAJ and then exponential backoff of retries 🙂
@U04V70XH6 the initial response time was very prompt, which is how I ended up just feeling confused about the whole situation 🙂
Morning!
morning
@raymcdermott I match your buds with a Buddon (Ness) and 2 rigs in the distance
So Clarissa is doing a side project with St Andrews Uni and Fife BC, something about the land. Anyhoo a rare white tailed eagle landed on West Sands on Monday, not seen for the last five years 🙂
Oh it got better, needed to pair with her on QGIS lol, all the R stuff she had down in minutes as she taught herself, as you know @U0525KG62.