Fork me on GitHub
#clojure-europe
<
2023-01-26
>
grav05:01:40

Mornin'!

Ben Sless06:01:49

When is it appropriate to pester someone about a PR? I received some feedback, fixed it quickly, and now I'm stuck waiting to see if the fixes are satisfactory 😕

grav06:01:54

That's one reason why we use a kind of "prior approval" of PRs: • "I think you should consider doing this and that, and with that in mind, I'll give a "

Ben Sless06:01:39

It's an OSS project and I couldn't implement all suggestions due to reasons, so this probably isn't an option

Jakub Holý (HolyJak)06:01:24

According to urgency I pester colleagues within hour(s), at most a day. OSS is different, and maintainers are very different. But if it has been couple days, I would kindly ask if they could approve...

seancorfield06:01:40

How long did it take them to respond to the PR in the first place with requests for changes? I would probably consider that to be their "cycle time" and wait at most twice that then ping the PR for additional feedback...

❤️ 2
slipset06:01:11

I tend to forget to respond to OSS PRs every now and then, and appreciate a reminder. I think that using exponential back off would be a nice strategy if multiple reminders are needed.

borkdude08:01:05

@UK0810AQ2 I think it's appropriate to send a reminder in a PR after a week or so? Everyone can forget

4
jackrusher10:01:55

@U04V15CAJ and then exponential backoff of retries 🙂

Ben Sless11:01:21

@U04V70XH6 the initial response time was very prompt, which is how I ended up just feeling confused about the whole situation 🙂

Ben Sless11:01:35

Thank you all for the ideas

lread14:01:03

Life events, good and bad, can sometimes distract us from OSS work too.

schmalz10:01:13

Morning all.

genRaiy10:01:54

Bud morning

❤️ 10
🍃 4
otfrom11:01:25

@raymcdermott I match your buds with a Buddon (Ness) and 2 rigs in the distance

❤️ 6
😍 2
jasonbell12:01:49

So Clarissa is doing a side project with St Andrews Uni and Fife BC, something about the land. Anyhoo a rare white tailed eagle landed on West Sands on Monday, not seen for the last five years 🙂

jasonbell12:01:10

Useless information I know but hey.

jasonbell13:01:11

Oh it got better, needed to pair with her on QGIS lol, all the R stuff she had down in minutes as she taught herself, as you know @U0525KG62.

jasonbell14:01:32

When I say “pair”, I mean rubberduck.

lemontea17:01:46

just took a bath and then I saw this… duckie

lemontea17:01:52

I played with GIS (postgresql extension + leaflet) about a year ago… it was a fun exercise. (but I had classmates having to do those kinds of work in a professional settings… not-as-fun 🙃)