clojure-dev

seancorfield 2024-03-11T17:54:57.402509Z

These seem to be new reflection warnings in tools.reader:

Reflection warning, clojure/tools/reader.clj:1025:74 - call to method setLength can't be resolved (target class is unknown).
Reflection warning, clojure/tools/reader.clj:1030:74 - call to method setLength can't be resolved (target class is unknown).
I haven't checked whether they are due to changes in tools.reader or Clojure 1.12 Alpha 9.

bronsa 2024-03-12T10:47:15.930859Z

applied the fix (TRDR-72). really thought we had warn-on-reflection enabled already

bronsa 2024-03-12T10:52:45.309119Z

released 1.4.1 with the fix

borkdude 2024-03-12T10:54:25.081849Z

thank you @bronsa!

Alex Miller (Clojure team) 2024-03-11T17:57:21.502219Z

so these are new as of ... 1.12.0?

seancorfield 2024-03-11T17:59:02.263069Z

Unclear at the moment. We did some dependency updates this morning (but not of Clojure which was already on alpha 9) so I haven't tracked down exactly what causes these new warnings...

seancorfield 2024-03-11T17:59:26.976829Z

(I posted mostly as an FYI in case anyone had an immediate response that might save me some work)

Alex Miller (Clojure team) 2024-03-11T17:59:40.154569Z

new to me, but we can look into it

Alex Miller (Clojure team) 2024-03-11T18:02:07.443449Z

can easily repro in the lib, doesn't seem related to 1.12, will look

Alex Miller (Clojure team) 2024-03-11T18:04:57.045619Z

looks like it was in "TRDR-71: source-logging-push-back-reader throws" change from Nov

seancorfield 2024-03-11T18:11:26.298759Z

Ah, interesting. I wonder why we've only just started seeing it?

> clojure -Stree  -M:build:cfml-affiliate:dev:+default:test | fgrep tools.reader
      X org.clojure/tools.reader 1.3.6 :older-version
    X org.clojure/tools.reader 1.3.6 :parent-omitted
    . org.clojure/tools.reader 1.3.6
    X org.clojure/tools.reader 1.3.4 :older-version
      X org.clojure/tools.reader 1.3.6 :older-version
    . org.clojure/tools.reader 1.4.0
We don't depend on it directly so it could be due to our round of minor updates this morning bringing in 1.4.0?

seancorfield 2024-03-11T18:11:56.006149Z

(we exclude known reflection warnings from all our deps but this was an "unknown") 🙂

seancorfield 2024-03-11T18:16:22.088829Z

Ah, it's due to moving from tools.build 0.9.6 to 0.10.0 which brings in an updated tools.namespace which in turn brings in the updated tools.reader.

borkdude 2024-03-11T19:29:40.936639Z

hmm, interesting, this should break lots of my graalvm native-image projects :)

borkdude 2024-03-11T19:30:15.636299Z

haven't run into it yet though