clojure-dev

dpsutton 2022-04-11T14:32:06.173459Z

I can make a jar with mvn package -Dmaven.test.skip and test with mvn test when screening tickets. But I see there’s a build.xml that seems to have lots of useful stuff in it, but that seems to not construct a classpath that includes clojure spec. Is build.xml outdated or am I not setting it up correctly?

Alex Miller (Clojure team) 2022-04-11T14:38:58.941469Z

what problem are you trying to solve?

dpsutton 2022-04-11T14:41:26.637359Z

The proper way to run tests and make a jar which includes changes. I saw that mvn test was listed in the documentation about screening tickets but not how to properly create a jar.

Alex Miller (Clojure team) 2022-04-11T14:41:55.615709Z

mvn test and mvn package are the proper way to run tests and package the jar

👍 1
Alex Miller (Clojure team) 2022-04-11T14:42:21.081439Z

that is what CI does during build and release

dpsutton 2022-04-11T14:42:22.430879Z

oh i see it now in .

Alex Miller (Clojure team) 2022-04-11T14:45:08.911549Z

the Ant build.xml is used (by the Maven build) but I would not recommend running it directly. there is a lot of history about how it ended up here. I have spiked a full Maven replacement (ow) and we've more recently looked at replacing it with tools.build, but hard to prioritize replacing a thing that works, however tortured it may be

2022-04-11T14:46:22.707639Z

> hard to prioritize replacing a thing that works, however tortured it may be the saddest truth

dpsutton 2022-04-11T14:46:58.438599Z

Makes sense. I just didn’t quickly notice how to make a jar and saw a “build.xml” which seemed to invite me to use its tasks. And wanted to know if I was doing it wrong. Thanks for the information.

imre 2022-04-11T17:19:56.946369Z

https://clojure.atlassian.net/browse/CLJ-2617 bit me again when doing a seemingly non-breaking update of a java dependency's version. While reify is recommended over proxy in most cases, proxy remains the only solution for extending classes which doesn't require AOT (as per https://puredanger.github.io/tech.puredanger.com/2011/08/12/subclassing-in-clojure/ )

Alex Miller (Clojure team) 2022-04-11T17:23:41.086169Z

https://ask.clojure.org/index.php/10383/using-proxy-might-make-otherwise-additive-change-breaking has just one vote, so would be interested to know if anyone else has encountered this

imre 2022-04-11T17:27:00.577389Z

Perhaps others have found a way to avoid this problem, I'd be interested in solutions if that's the case