Fork me on GitHub
#clojure-dev
<
2021-02-22
>
mpenet15:02:21

shouldn't assert docstring make explicit the fact they will cause Errors to be thrown and not exceptions?

mpenet15:02:43

the docstring is just wrong it seems in master

mpenet16:02:26

I can send a patch if you'd like

alexmiller16:02:40

here, I read exception (lower case e) as any kind of exception, not necessarily as "subclass of Exception"

alexmiller16:02:13

but I'm on board with making it more precise

alexmiller16:02:28

we look at bugs based (at least in part) on the number of votes on ask.clojure

potetm17:02:31

Are Errors subclasses of Exception?

potetm17:02:15

Looks like it’s its own branch under Throwable.

potetm17:02:43

Ah > not necessarily as “subclass of Exception” Misread that bit.

borkdude17:02:00

Seems not:

user=> (.isAssignableFrom Exception Error)
false
user=> (.isAssignableFrom Error Exception)
false

potetm17:02:55

Voted 🙂