Better take it here than twitter I guess.

https://twitter.com/puredanger/status/1028364021257388032

I might just be dreaming up scenarios, but I’m thinking that tooling writers might want to highlight the symbol in the error message.

With the :data, we have the symbol at hand, but you’d still have to parse the message if you wanted to highlight it.

Imagine I wanted to display the error as:

Cause: first argument to def must be a Symbol

or even:

Cause: first argument to def must be a symbol

(should symbol be Symbol or symbol?)

Anyways, great work on this!

the string “first argument to def must be a Symbol” is coming out of the compiler

nothing has changed there, that’s a hand-crafted Compiler message

so in this particular case, this is kind of outside the realm of what I’m working on (which is improving the categorical building and printing of exceptions)

the wrapper here is (separately) capturing def as the symbol being compiled (this happens at a higher level)

Ok, thanks for explaining.

I pushed current patch state up to https://dev.clojure.org/jira/browse/CLJ-2373 - does not address test regressions yet