Fork me on GitHub
#clojure-dev
<
2018-08-11
>
slipset19:08:52

Better take it here than twitter I guess.

slipset19:08:05

I might just be dreaming up scenarios, but I’m thinking that tooling writers might want to highlight the symbol in the error message.

slipset19:08:09

With the :data, we have the symbol at hand, but you’d still have to parse the message if you wanted to highlight it.

slipset19:08:46

Imagine I wanted to display the error as:

slipset19:08:06

Cause: first argument to def must be a Symbol

slipset19:08:48

Cause: first argument to def must be a symbol

slipset19:08:24

(should symbol be Symbol or symbol?)

slipset19:08:35

Anyways, great work on this!

alexmiller19:08:37

the string “first argument to def must be a Symbol” is coming out of the compiler

alexmiller19:08:05

nothing has changed there, that’s a hand-crafted Compiler message

alexmiller19:08:12

so in this particular case, this is kind of outside the realm of what I’m working on (which is improving the categorical building and printing of exceptions)

alexmiller19:08:22

the wrapper here is (separately) capturing def as the symbol being compiled (this happens at a higher level)

slipset19:08:57

Ok, thanks for explaining.

alexmiller21:08:30

I pushed current patch state up to https://dev.clojure.org/jira/browse/CLJ-2373 - does not address test regressions yet

👍 2