@bronsa Does your recent change to tools.reader now use normal (not TCO-optimized) recursion, and thus potentially a call stack that is as deep as long sequences of things to read in input files can be?

Pretty subtle bug, by the way. Thinking about ways that a linter like Eastwood might be able to warn about such a thing sounds pretty tricky, and like anything one would try to detect it would have lots of false positives and negatives.

@andy.fingerhut the recursion is only in whitespace paths

so stack depth shouldn't be an issue

if it becomes, we can always trampoline

and # dispatch forms, looks like?

But I guess those would rarely nest nearly as deeply as whitespace.

right

@andy.fingerhut https://github.com/clojure/tools.reader/commit/5ec80af5729efad880724fa1c87fd7be2ef5608a

I'll cut 1.2.1, thanks

Cool. I wasn't even very deeply concerned after your explanation above, but that looks like one less Eastwood issue in the future. 🙂 Thanks.