Fork me on GitHub

@dnolen it looks like core.match 0.3.0-alpha4 has a dependency on tools.analyzer.jvm and is requiring it but never actually using it (apart from defining analyze which is never used anyway) , this is adding a needles couples of seconds in compilation times -- could that be removed?


@bronsa it could be, I planned to use it at some point - but unclear when I will have time to do that work


@alexmiller export PATH=$PATH:$PWD/src/main/resources/clj should be export PATH=$PATH:$PWD/src/main/resources in the readme

Alex Miller (Clojure team)14:07:49

@bronsa I can help with that if you tell me what needs to be done


yeah I'll just attach a patch in jira


it's literally just removing a few lines of code


if you want to do it, just remove the tools.analyzer requires from match.clj, and the defn analyze

Alex Miller (Clojure team)14:07:03

should I release 0.3.0-alpha5? :)


yes please


@alexmiller also while you're here, the clj script doesn't seem to work , $tools_cp seems to be missing the tools.deps.alpha jar

Alex Miller (Clojure team)14:07:26

hmm, could be - I actually have a working installer but not ready to release that stuff yet so I’m kind of backing into the manual install


cp=$("$JAVA_CMD" -Xmx256m -classpath "$HOME/.m2/repository/org/clojure/tools.deps.alpha/0.1.11-SNAPSHOT/tools.deps.alpha-0.1.11-SNAPSHOT.jar:$tools_cp" clojure.main -m "$project_deps" "$project_cache_dir" "${tools_args[@]}")
I hotpatched it like this and it works --obv not the real fix

Alex Miller (Clojure team)14:07:52

just need to modify how the cp gets set


@alexmiller is the intent of tools.deps to also use it for CLJS or CLJ only? eg. add a :provider for :npm?

Alex Miller (Clojure team)14:07:04

open to expanding it to CLJS but no thought has gone into that yet


ok. I guess it doesn’t make much sense since npm doesn’t have the concept of a classpath but I suppose adding things to the classpath could be optional

Alex Miller (Clojure team)14:07:35

well the whole point of this is to build classpaths


thanks for the core.match release!


@alexmiller small typo in your slides:, but I guess you know about it

Alex Miller (Clojure team)15:07:52

that’s in the immutable past man


the irony of putting a typo in a typo comment


and slack is slow as hell today


editing in slack is always crazy slow


took >1 min for the edit 😞

Alex Miller (Clojure team)15:07:30

@bronsa @dnolen core.match 0.3.0-alpha5 released without tools.analyzer.jvm dependency


@alexmiller It looks like deps isn’t designed to be a complete project description, correct? In particular, no mention is made of source paths. So it’s only designed for execution, and not to be used for building?


Actually I see that’s explicitly in the presentation - NM.

Alex Miller (Clojure team)22:07:37

Still pending another discussion with rich

Alex Miller (Clojure team)22:07:03

For projects that don't require special building I think there is a lot of value in supporting a way to specify what parts of the project are included in the classpath for use


Right, source paths are really part of the classpath for most Clojure projects


@cfleming mind posting a link to the presentation?


I must’ve missed it


No video yet unfortunately.