Fork me on GitHub
#clojure-dev
<
2017-07-25
>
bronsa10:07:53

@dnolen it looks like core.match 0.3.0-alpha4 has a dependency on tools.analyzer.jvm and is requiring it but never actually using it (apart from defining analyze which is never used anyway) , this is adding a needles couples of seconds in compilation times -- could that be removed?

dnolen10:07:15

@bronsa it could be, I planned to use it at some point - but unclear when I will have time to do that work

bronsa14:07:35

@alexmiller export PATH=$PATH:$PWD/src/main/resources/clj should be export PATH=$PATH:$PWD/src/main/resources in the readme

alexmiller14:07:49

@bronsa I can help with that if you tell me what needs to be done

alexmiller14:07:59

or patch etc

bronsa14:07:11

yeah I'll just attach a patch in jira

bronsa14:07:19

it's literally just removing a few lines of code

bronsa14:07:39

if you want to do it, just remove the tools.analyzer requires from match.clj, and the defn analyze

alexmiller14:07:12

@bronsa did it - please check

alexmiller14:07:37

tests pass :)

alexmiller14:07:03

should I release 0.3.0-alpha5? :)

bronsa14:07:07

yes please

bronsa14:07:48

@alexmiller also while you're here, the clj script doesn't seem to work , $tools_cp seems to be missing the tools.deps.alpha jar

alexmiller14:07:26

hmm, could be - I actually have a working installer but not ready to release that stuff yet so I’m kind of backing into the manual install

alexmiller14:07:52

thx for the heads up

bronsa14:07:25

cp=$("$JAVA_CMD" -Xmx256m -classpath "$HOME/.m2/repository/org/clojure/tools.deps.alpha/0.1.11-SNAPSHOT/tools.deps.alpha-0.1.11-SNAPSHOT.jar:$tools_cp" clojure.main -m clojure.tools.deps.alpha.makecp "$project_deps" "$project_cache_dir" "${tools_args[@]}")
I hotpatched it like this and it works --obv not the real fix

alexmiller14:07:52

just need to modify how the cp gets set

thheller14:07:24

@alexmiller is the intent of tools.deps to also use it for CLJS or CLJ only? eg. add a :provider for :npm?

alexmiller14:07:47

for the moment, CLJ

alexmiller14:07:04

open to expanding it to CLJS but no thought has gone into that yet

thheller14:07:48

ok. I guess it doesn’t make much sense since npm doesn’t have the concept of a classpath but I suppose adding things to the classpath could be optional

alexmiller14:07:35

well the whole point of this is to build classpaths

bronsa15:07:24

thanks for the core.match release!

mpenet15:07:32

@alexmiller small typo in your slides: https://github.com/clojure/brew-isntaller, but I guess you know about it

alexmiller15:07:52

that’s in the immutable past man

mpenet15:07:01

the irony of putting a typo in a typo comment

mpenet15:07:21

and slack is slow as hell today

bronsa15:07:40

editing in slack is always crazy slow

mpenet15:07:57

took >1 min for the edit 😞

alexmiller15:07:30

@bronsa @dnolen core.match 0.3.0-alpha5 released without tools.analyzer.jvm dependency

cfleming22:07:18

@alexmiller It looks like deps isn’t designed to be a complete project description, correct? In particular, no mention is made of source paths. So it’s only designed for execution, and not to be used for building?

cfleming22:07:07

Actually I see that’s explicitly in the presentation - NM.

alexmiller22:07:37

Still pending another discussion with rich

alexmiller22:07:03

For projects that don't require special building I think there is a lot of value in supporting a way to specify what parts of the project are included in the classpath for use

cfleming23:07:33

Right, source paths are really part of the classpath for most Clojure projects

anmonteiro23:07:10

@cfleming mind posting a link to the presentation?

anmonteiro23:07:22

I must’ve missed it

cfleming23:07:41

No video yet unfortunately.