@bronsa I'm trying to use tools.reader on *in* which is a clojure.lang.LineNumberingPushbackReader but that does not seem to work

clojure.lang.ExceptionInfo: clojure.lang.LineNumberingPushbackReader cannot be cast to java.io.InputStream {:type :reader-exception}
	at clojure.core$ex_info.invokeStatic(core.clj:4725)
	at clojure.core$ex_info.invoke(core.clj:4725)
	at clojure.tools.reader$read_STAR_.invokeStatic(reader.clj:934)
	at clojure.tools.reader$read_STAR_.invoke(reader.clj:897)
	at clojure.tools.reader$read.invokeStatic(reader.clj:965)
	at clojure.tools.reader$read.invoke(reader.clj:942)

it all looks like it should be supported, all I do is (reader/read opts *in*)

@thheller upgrade the tools.reader dependency

I think only the last version supports that

or one of the latest

yeah

which one is that? I have tools.reader-1.0.0-beta3.jar

it only works since 1.0.0-alpha1

@thheller uh?

user=> (require '[clojure.tools.reader :as r])
nil
user=> (r/read *in*)
1
1

it is the one that comes with clojurescript I think

are you sure you don't have an older version on your classpath

(io/resource "clojure/tools/reader.clj")

#object[java.net.URL 0x642ac8fe "jar:file:/Users/zilence/.m2/repository/org/clojure/tools.reader/1.0.0-beta3/tools.reader-1.0.0-beta3.jar!/clojure/tools/reader.clj"]

try and read #:foo{:bar 1}

if that fails, you're using an older version

if it doesn't, can you try and give me a minimal repro? as you can See above I just tried it and it worked fine for me

hmm it works if I call it in the repl directly

well the repl doesn't use tools.reader

i meant (r/read-string "#:foo{:bar 1}")

if that fails, you might have multiple versions of tools.reader in your classpath or something like that

that works just fine

:/

hmm

what's the value of opts? although it shouldn't make any difference

opts
         {:eof eof-sentinel
          :read-cond :allow
          :features #{:cljs}}

yeah doesn't matter

right, so just to make sure if you eval (reader/read *in*) and type 1 you get that exception?

no if I run that in the REPL it works just fine

then what causes it to fail?

form
         (binding [*ns*
                   (create-ns ns)

                   ana/*cljs-ns*
                   ns

                   ana/*cljs-file*
                   name

                   reader/*data-readers*
                   tags/*cljs-data-readers*

                   reader/*alias-map*
                   (merge reader/*alias-map*
                     (:requires ns-info)
                     (:require-macros ns-info))]

           (prn [:reading-from *in* opts])
           (try
             (reader/read opts in)
             (catch Exception e
               (prn [:wtf (.getMessage e)])
               (throw e))))

[:reading-from #object[clojure.lang.LineNumberingPushbackReader 0x726ff63d "[email protected]"] {:eof #object[java.lang.Object 0x208ac70d "[email protected]"], :read-cond :allow, :features #{:cljs}}]

[:wtf "clojure.lang.LineNumberingPushbackReader cannot be cast to java.io.InputStream"]

how is in defined?

*in*

wait what

are you sure

it works if I actually use *in* ...

teh fuck ... I'm sorry :slightly_smiling_face:

that sounds like somethingis calling (input-stream-reader *in*)

or somethign like that

yeah exactly

doh

thanks and sorry again for wasting your time

no worries

is there any way to get all this to work with source-logging-pushback-reader?

wait let me try this with actual *in* first .. not that I mess that up again

k it works, just had some messed up repl state :wink:

@alexmiller how "official" is the socket REPL sessions stuff? I have some thoughts on the subject but nothing except clojure.core.server/*session* seems to exist?

looking at this: http://dev.clojure.org/display/design/Socket+Server+REPL

That all got yanked out before the final

So it's not a thing

are there any open tickets or discussions about this?

anything already in progress?

No, no plans to do anything more with that right now

But you can write your own socket server that does whatever you need

yeah just checking, the building blocks are basically there to do what I need

They can be programmatically installed too, so you can set up whatever you need before you start the server

yeah I just have one issue so far when it comes to nesting one REPL in another

Should work - what's the issue?

specifically a CLJS repl, say I'm at the normal clojure.main/repl

I then eval (cljs) or something

this then starts its own loop off *in* and prints to *out* as intended

the issue is if you have a tool reading *out* trying to do things like syntax highlighting (ie. Cursive)

is that it cannot identify which "level" this came from

Yeah, not sure what the repl could do about that

the (cljs) loop can rebind *out* but at some point some output must go the real *out*

I have a repo with some sketches of how tools could work with the socket repl at https://github.com/puredanger/replicant

my idea was that every new loop, informs the current loop that it is no longer in charge

so it should stop parsing *out* and just pass it through maybe?

basically this would happen as soon as you bind clojure.core.server/*session*

just a rough idea at this point

Generally it's easiest to design the repl you want rather than to nest

yeah probably

The main repl is very customizable

yeah as long as you stick to in,out,err

but I also have the output of the cljs compiler I must put somewhere

and other status message like things

would be nice to have a standard way of doing things that is not nrepl :wink:

the nesting stuff is just so much nicer

anyways, I will try some things. just wanted to check if there was some official progress on that front.

If you want a stream compliant client, then in/out/err is all you have. :)

yes, but there should be a way to tools provide "more".

ie. I start a loop and bind *session* with {:call-me-with-compiler-output some-fn}

the nested loop can check that binding and call that fn if it supports that feature

otherwise is can just print to *out*

just a rough idea so far, might totally not work out. basically I'm just looking for a way to "extend" the standard stream model. If I'm in an IDE I want pretty output, when I just telnet somewhere it is ok to just have text

(loop []
  (prompt)

  (let [form
        (read)

        [js warnings]
        (cljs-compile form)]

    (if-let [cb (get *session* :cljs/compiler-warnings)]
      (cb warnings)
      (print-warnings warnings))

    (let [result (eval js)]

      (print result)
      (recur))))

if whoever created the parent loop binds *session* with {:cljs/compiler-warnings (fn [warnings] ...)} they go somewhere else

that is the idea at least, probably terrible in practice

nevermind the fact that a cljs loop looks very different due to eval happening in another runtime, but the idea is the same