@bronsa in the process of testing the new async code, I’ve run into a problem with the ASYNC-138 patch, which I’ve described at http://dev.clojure.org/jira/browse/ASYNC-138

I’ve reverted the change for now

seems fixable

happy to take a second look tomorrow if you have something

@alexmiller i think i can fix it in like 10 minutes

switching the type hint from the local to the init

well, don’t rush :)

I’m off to other things for now

but will pick it up again tomorrow

e.g. (let [^foo a (a')]) -> (let [a ^foo (a')]) should make prim type hints valid not going to work for primitives, need to explicitely unbox

yeah, that makes sense

altho I'll have to double check that that unboxes the local correctly

i'll add a bunch of test cases

tfw I just found another type hinting related bug in Compiler.java :(

user=> (set! *warn-on-reflection* true)
true
user=> (let [a ^int (identity ((fn [] 1)))] (Integer/valueOf a))
1
user=> (let [a ^int ((fn [] 1))] (Integer/valueOf a))
Reflection warning, NO_SOURCE_PATH:3:27 - call to static method valueOf on java.lang.Integer can't be resolved (argument types: unknown).
1

first one only works when direct linking is enabled, when direct linking is disabled both cause a reflection warning

meh

😕

I've argued in the past that that's an incorrect type hinting usage as that's unboxing and not hinting

and we should use (int ((fn [] 1))) instead

so I'm just going to ignore it