Fork me on GitHub
#clojure-dev
<
2016-12-13
>
bronsa14:12:41

@alexmiller i can't seem to be able to deploy tools.reader using the new jenkins:

[ERROR] Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin:1.4.4:deploy (default-deploy) on project tools.reader: Execution default-deploy of goal org.sonatype.plugins:nexus-staging-maven-plugin:1.4.4:deploy failed: A required class was missing while executing org.sonatype.plugins:nexus-staging-maven-plugin:1.4.4:deploy: org/sonatype/aether/version/InvalidVersionSpecificationException

bronsa14:12:06

anything i need to update in my pom.xml?

alexmiller14:12:34

Yeah, you'll need to update for the new infrastructure. Give me 5 minutes

alexmiller14:12:51

ok, I just updated the pom to use the new parent pom

alexmiller14:12:01

give it another try, hopefully that’s it

bronsa14:12:57

yeah that did it. cheers

alexmiller14:12:41

thanks for the heads up - I’m going to update all the other contribs similarly

alexmiller17:12:31

all other contribs have been updated so should not have issues on next deploy

alexmiller17:12:44

but of course, happy to figure it out if they do

seancorfield17:12:43

Beyond updating to the new parent pom version, is there anything else needed to build .cljc files now?

seancorfield17:12:14

(not that I’m planning .cljc files for clojure.java.jdbc of course… I’m just curious as to what’s involved)

alexmiller18:12:18

I don’t think much else?

alexmiller18:12:51

your clojure build will work as long as the cljc files are visible in the source dirs

alexmiller18:12:26

and they will get included in the jar due to the same thing

alexmiller18:12:16

maven builds are not currently doing anything with cljs, so as long as that is set up to include cljs in the src dirs and also to have some independent test process, seems like that should work

alexmiller18:12:36

although data.xml is now doing cljs tests via nashorn, which might be something we should replicate

alexmiller18:12:03

as that’s included in the actual maven test run and will fail the build as desired

seancorfield19:12:01

Sounds good. Thanks @alexmiller I’m interested in this because I’m now maintaining Expectations and that is written as .cljc files and I’d like to have automated testing for the cljs half of the picture.