This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
- # admin-announcements (296)
- # beginners (19)
- # boot (40)
- # cider (77)
- # clojure (139)
- # clojure-australia (2)
- # clojure-bangladesh (6)
- # clojure-dev (19)
- # clojure-japan (25)
- # clojure-russia (23)
- # clojure-sg (1)
- # clojure-uk (4)
- # clojurescript (131)
- # datomic (41)
- # editors (42)
- # ldnclj (35)
- # off-topic (11)
- # reagent (10)
I'd love to have someone address the comments raised in http://dev.clojure.org/jira/browse/CLJ-1453 so that there was a good patch on it
@alexmiller: the old patches doesn't apply anymore. There are some git-fu I could use (just to maintain the old commits) or is better to start off new ones?
there have been significant changes in some relevant parts of the code
you could try "git apply --reject" to apply the hunks that will apply
whoa git dark magic... now I'm in the middle of a rebase, just fix and continue, right?
additionally, the original evaluation likely needs to be re-done to catch anything new that was introduced (I tried not to introduce new instances of this in patches during 1.7 but I might have missed something)
@alexmiller: the patch for CLJ-1208 breaks one of @ztellman's potemkin macros, it assumes that deftype expands to (deftype foo ..) but the patch changes it to expand to (deftype* ns/foo ..), I have a fix for potemkin, would you rather have me extend the patch for CLJ-1527 to relax
deftype so that
(deftype ns/foo) just ignores the ns part rather than failing at compile time?
@alexmiller: yeah, just wanted to check in case you considered it a breaking change (I think potemkin is bound to break from time to time as it relies on specific macroexpansions)