Fork me on GitHub
#clojars
<
2017-05-05
>
flyboarder00:05:08

@danielsz I am getting a strange error, could you explain possibly?

danielsz02:05:53

No, sorry, but then again, I'm not the right person to ask. Maybe @danielcompton?

danielcompton02:05:45

Looks like it's trying to deploy a .finalized file?

danielcompton02:05:23

Can you share the full deploy log?

flyboarder03:05:48

@danielcompton where is the deploy log? or do you mean the stack trace?

danielcompton09:05:59

@flyboarder all of the logs that were part of your deploy command

danielcompton09:05:54

but the problem seems to be that you uploaded a .finalized file which had no checksums

tcrawley16:05:20

@flyboarder hmm, I believe we write a .finalized file to the tmp upload repo, but it should be excluded from the checksum check. I'll take a look

tcrawley16:05:57

@flyboarder it looks like the cookie store for the aether client is being reused between deploy calls. Are you doing these deploys from a repl?

tcrawley16:05:42

if the cookies are reused, then the same tmp repo is used, which is what appears to be happening here (all the snapshot deploys are ending up in the same tmp)

tcrawley16:05:06

not that deploying from the repl is a bad thing, I'm just trying to figure out the cause here

flyboarder16:05:30

@tcrawley I think you are correct, i have only found reference to this file in the clojars-web repo, and I am deploying from boot continuously

tcrawley16:05:02

ok, I'll take a look and see what we can do to fix this

tcrawley16:05:10

I'd like to support that usage

tcrawley16:05:39

in the meantime, you should be able to deploy by invoking boot from the command-line, if that's an option

flyboarder16:05:08

yeah it works the first go round, but when the watch task reruns the push command it breaks

tcrawley16:05:23

and it looks like this only affects snapshots, from looking at the code

tcrawley16:05:04

ok, I think I see a way to fix it

flyboarder16:05:03

I have not tried with releases, currently using snapshots as I dont want 50 new releases when im testing the deployment

tcrawley16:05:45

actually, this would break with releases as well, now that I'm taking a closer look

flyboarder16:05:27

oh man I spent all day yesterday making sure it wasnt me causing the propblem XD

tcrawley16:05:27

sorry about that :(

flyboarder17:05:14

@tcrawley do you want a github issue?

tcrawley17:05:46

@flyboarder that would be swell, thanks!

tcrawley17:05:29

@flyboarder thanks. We have a test that is doing almost the exact thing you are, but it succeeds :( Do you have a locally modified boot.aether or a modified build of pomegranate, perchance?

tcrawley17:05:01

our test isn't using boot, but our invocation of aether looks the same as boot's

flyboarder17:05:48

nope! im basically using this build pipeline boot watch build-jar push-snapshot which works without the watch command

flyboarder17:05:05

but on subsequent deployments it fails with that error

tcrawley17:05:33

is push-snapshot your task? or is it built-in?

flyboarder17:05:11

it’s provided by bootlaces, but it’s just a task that collects clojars creds and uses the built-in push task

tcrawley17:05:47

yeah, that does nothing special

flyboarder17:05:10

I tracked the trace stack down to the aether/deploy call

flyboarder17:05:25

so i thinks it’s the server

tcrawley17:05:57

yes, definitely, we have a bug. I just want to add a test for it, so I know when I've fixed it/break it in the future

tcrawley17:05:27

basically, I need to figure out how to get aether/deploy to reuse a cookie store between calls

tcrawley17:05:53

we do multiple deploys in the same test, but it doesn't share the cookies

tcrawley17:05:01

but does under boot, apparently

flyboarder17:05:24

that makes sense since the worker pod is constructed only once when the task it built

tcrawley17:05:41

I agree, except two aether/deploy calls right after each other in the clojars tests don't share :(

flyboarder18:05:13

@tcrawley I fixed it by monkey-patching the push task, now uses a new pod each time the task runs, fixed the issue!

tcrawley18:05:36

heh, "fixed".

tcrawley18:05:08

good deal. I may have you unfix it and try after I push a fix if you are cool with that

flyboarder18:05:00

yep, I’m not submitting the patch up to boot, instead im including it with my custom task