Fork me on GitHub
#cljsrn
<
2022-08-19
>
Oliver George07:08:35

So I blinked and now it seems react native components are published as pure typescript. Is that something we support=

Oliver George23:09:36

@U050B88UR quick sanity check. Do you think Krell will work with a node module which only includes typescript source files? In this case seems like krell doesn't generate the require statement when the node module "main" is "src/index.ts" My suspicion is that there's a file type filter somewhere (perhaps in the cljs source code) and ".ts" is not whitelisted. In the realm of React Native this seems supportable because the metro bundler translates for us.

dnolen02:09:09

Sorry missed this - isn't this covered by bundlers?

Oliver George09:09:03

Thanks for coming back to it. My suspicion is that the Metro bundler isn't involved in collating the npm requires. That the https://github.com/vouch-opensource/krell/blob/master/src/krell/passes.clj#L61 (not krell code) doesn't pass through npm deps with expected data. I should be able to prove that but currently wrestling with React Native / Mac M1 compatibility issues.

dnolen17:09:35

that’s for assets only pretty sure, I think we just rely on ClojureScript for unresolved nses coming from node_modules

dnolen17:09:59

I think we haven’t seen this because we’re only an older RN

dnolen17:09:44

gotta say this churn is such a time waste

Oliver George07:08:15

We need a major version upgrade due to compatibility issues with Android API 30

Oliver George07:08:36

Seems like we could work around by forking and converting the TS back to JS.

Oliver George07:08:57

But perhaps we're missing some common approaches used by others.

thheller07:08:07

they have always been published as various kinds of non-actually JS. nothing new really. doesn't affect CLJS in any way either since you've always been running through metro which handles that