I'm having an issue when adding new JavaScript components, @joshmiller. I've added an issue: https://github.com/joshuamiller/react-native-template-cljs-krell-storybook/issues/1 (It seems very similar to this: https://github.com/vouch-opensource/krell/issues/142)
I've installed Watchman, and tried again, but unfortunately the issue is still there. π
@larskristian.marontel Good news, bad news. I checked out the latest version of your repo and it ran fine for me:
Iβm on macOS, so itβs very possible thereβs some OS-level difference here.
Actually, I will say, it may be worth checking out your βbrokenβ repo into a new directory and trying to run it from there. I once solved a bundler issue by doing that even after all the cache-clearing instructions failed.
Did you see the issue on just the bare skeleton, or did it only happen when you added a second component?
I would definitely try to rm -rf node_modules && yarn install and try again as well.
I've done a couple of other things as well, like adding a newer version of react-native-tcp-socket (https://github.com/vouch-opensource/krell/issues/148), and making some changes to styling. I've tried removing node_modules and running yarn install, and it seems to remove the error, but I then had problems with Metro/REPL not picking up changes. I was able to get everything to work again by reinstalling the REPL dependencies (`clj -M -m cljs.main -co "{:deps-cmd \"yarn\"}" --install-deps`), but that is quite cumbersome, and it appears I get the mentioned error again if I add another JS component.
I believe when you do that reinstalling REPL deps step, itβs actually going to overwrite your upgraded react-native-tcp-socket version, along with possibly your react-native version, so I would double-check that.
Yeah, it does, so I also did upgrade that specific library afterwards.
Iβm not surprised about the error itself, but more surprised that you have it working, then you add a component, and then it fails.
Here's my story so far: https://github.com/Zeniten/rn-krell-storybook
(Before I tried adding another component, that is.)
Oh, btw, I had trouble installing Watchman when setting up RN, so I skipped that. I'm quite new to RN, so I'm not sure how crucial it is.
Oh, that might be an issue. Watchman is what the bundler uses to detect new changes and include them in the build. It might not be picking up your new component.
If you have a working project and add a component to it, can you try quitting everything, then running yarn run-android and clj -M -m krell.main -co build.edn -c -r again?
Yeah, got the error.
https://github.com/Zeniten/rn-krell-storybook/commit/baa2503ca788eb786f3dd44689d86a7d75b13d09
Ah, I forgot to rename the component this time. 1 sec.
Hm, one thing you should definitely change is that youβre nesting a Text component inside another Text
I'll fix that too, and check.
Same error. https://github.com/Zeniten/rn-krell-storybook/commit/c4cd765e9fd7c21863b9de287094a9fda008e4d3
I guess trying to get Watchman set up would be a nice next step. Also, I could try making changes in another editor. I've had some issues with Emacs and temporary files in the past.
What does target/krell_npm_deps.js look like?
module.exports = {
krellNpmDeps: {
"../js/Welcome.js": require('../js/Welcome.js'),
"../js/Component.js": require('../js/Component.js') }
};Ok, so it looks like Krell is properly picking up your JS
I just tried making changes in VS Code. It didn't affect the issue.
I'll try getting Watchman up an running sometime later.
Bah, cloning into a new directory didn't solve it. I guess it's the OS then, or my previous history with mucking about with this install.
Thanks for all your input, though, Josh! π
No problem! Sorry it's not working. Let me know if you give it another shot and want a hand.
Alright, I'll try that.