This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2022-06-06
Channels
- # announcements (3)
- # asami (41)
- # aws (2)
- # babashka (65)
- # beginners (85)
- # biff (7)
- # calva (10)
- # cider (5)
- # cljsrn (32)
- # clojure (6)
- # clojure-czech (3)
- # clojure-europe (10)
- # clojure-russia (4)
- # clojure-uk (3)
- # clojurescript (5)
- # core-typed (7)
- # data-science (13)
- # datomic (43)
- # etaoin (4)
- # fulcro (22)
- # graphql (3)
- # gratitude (1)
- # helix (1)
- # joyride (2)
- # liquid (10)
- # malli (16)
- # off-topic (10)
- # other-languages (1)
- # polylith (10)
- # reitit (3)
- # scittle (7)
- # shadow-cljs (103)
- # tools-deps (10)
- # vim (9)
- # xtdb (2)
I'm having an issue when adding new JavaScript components, @joshmiller. I've added an issue: https://github.com/joshuamiller/react-native-template-cljs-krell-storybook/issues/1 (It seems very similar to this: https://github.com/vouch-opensource/krell/issues/142)
Did you see the issue on just the bare skeleton, or did it only happen when you added a second component?
I would definitely try to rm -rf node_modules && yarn install
and try again as well.
I've done a couple of other things as well, like adding a newer version of react-native-tcp-socket
(https://github.com/vouch-opensource/krell/issues/148), and making some changes to styling. I've tried removing node_modules and running yarn install, and it seems to remove the error, but I then had problems with Metro/REPL not picking up changes. I was able to get everything to work again by reinstalling the REPL dependencies (`clj -M -m cljs.main -co "{:deps-cmd \"yarn\"}" --install-deps`), but that is quite cumbersome, and it appears I get the mentioned error again if I add another JS component.
I believe when you do that reinstalling REPL deps step, it’s actually going to overwrite your upgraded react-native-tcp-socket
version, along with possibly your react-native
version, so I would double-check that.
I’m not surprised about the error itself, but more surprised that you have it working, then you add a component, and then it fails.
Oh, btw, I had trouble installing Watchman when setting up RN, so I skipped that. I'm quite new to RN, so I'm not sure how crucial it is.
Oh, that might be an issue. Watchman is what the bundler uses to detect new changes and include them in the build. It might not be picking up your new component.
If you have a working project and add a component to it, can you try quitting everything, then running yarn run-android
and clj -M -m krell.main -co build.edn -c -r
again?
https://github.com/Zeniten/rn-krell-storybook/commit/baa2503ca788eb786f3dd44689d86a7d75b13d09
Hm, one thing you should definitely change is that you’re nesting a Text
component inside another Text
Same error. https://github.com/Zeniten/rn-krell-storybook/commit/c4cd765e9fd7c21863b9de287094a9fda008e4d3
I guess trying to get Watchman set up would be a nice next step. Also, I could try making changes in another editor. I've had some issues with Emacs and temporary files in the past.
What does target/krell_npm_deps.js
look like?
module.exports = {
krellNpmDeps: {
"../js/Welcome.js": require('../js/Welcome.js'),
"../js/Component.js": require('../js/Component.js') }
};
I've installed Watchman, and tried again, but unfortunately the issue is still there. 😞
@U9CU2PQPM Good news, bad news. I checked out the latest version of your repo and it ran fine for me:
Actually, I will say, it may be worth checking out your “broken” repo into a new directory and trying to run it from there. I once solved a bundler issue by doing that even after all the cache-clearing instructions failed.
Bah, cloning into a new directory didn't solve it. I guess it's the OS then, or my previous history with mucking about with this install.
No problem! Sorry it's not working. Let me know if you give it another shot and want a hand.